--- Log opened vr jul 08 00:00:52 2016 00:20 -!- ybronhei (purple): has joined #vdsm 00:35 -!- hchiramm: has quit [Ping timeout: 250 seconds] 00:49 -!- ybronhei: has quit [Ping timeout: 264 seconds] 00:51 -!- kaminohana (Kami no Hana): has joined #vdsm 00:52 -!- hchiramm (hchiramm): has joined #vdsm 01:33 -!- hchiramm: has quit [Ping timeout: 276 seconds] 01:34 -!- ybronhei (purple): has joined #vdsm 01:46 -!- hchiramm (hchiramm): has joined #vdsm 01:52 -!- ybronhei: has quit [Ping timeout: 240 seconds] 01:58 -!- tiraboschi_: has left #vdsm ["PING 1467935896"] 02:49 -!- nsoffer: has quit [Ping timeout: 258 seconds] 02:50 -!- ahino: has quit [Ping timeout: 264 seconds] 02:59 -!- ahino (purple): has joined #vdsm 05:53 -!- kaminohana: has quit [Ping timeout: 264 seconds] 06:29 -!- shubhendu (Shubhendu): has joined #vdsm 06:30 -!- shubhendu: has quit [Client Quit] 06:31 -!- shubhendu (Shubhendu): has joined #vdsm 07:02 -!- ndarshan (Darshan n): has joined #vdsm 07:06 -!- ahino: has quit [Remote host closed the connection] 07:13 -!- tim (Tim): has joined #vdsm 07:34 -!- hchiramm: has quit [Ping timeout: 276 seconds] 07:51 -!- hchiramm (hchiramm): has joined #vdsm 07:51 -!- ishaby (Idan Shaby): has joined #vdsm 07:55 -!- sbonazzo (purple): has joined #vdsm 08:29 -!- mskrivanek_away is now known as mskrivanek 08:41 -!- shubhendu_ (Shubhendu): has joined #vdsm 08:41 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 08:42 -!- shubhendu: has quit [Ping timeout: 244 seconds] 08:50 -!- fromani (Francesco Romani): has joined #vdsm 08:52 -!- ishaby: has quit [Ping timeout: 246 seconds] 09:05 -!- shubhendu_: has quit [Quit: Ex-Chat] 09:06 -!- shubhendu_ (Shubhendu): has joined #vdsm 09:10 -!- tiraboschi_ (purple): has joined #vdsm 09:12 -!- tiraboschi_: has left #vdsm [] 09:14 -!- rmohr: has quit [Remote host closed the connection] 09:16 -!- rmohr (Roman Mohr): has joined #vdsm 09:35 -!- ishaby (Idan Shaby): has joined #vdsm 09:50 -!- ishaby: has quit [Ping timeout: 276 seconds] 09:50 -!- ishaby (Idan Shaby): has joined #vdsm 09:56 -!- ahino (purple): has joined #vdsm 10:11 -!- irit (purple): has joined #vdsm 10:14 -!- pkliczew: has quit [Ping timeout: 252 seconds] 10:17 -!- ishaby: has quit [Ping timeout: 252 seconds] 10:21 -!- ishaby (Idan Shaby): has joined #vdsm 10:26 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 10:33 -!- ybronhei (purple): has joined #vdsm 10:39 -!- ishaby: has quit [Ping timeout: 264 seconds] 10:40 -!- ishaby (Idan Shaby): has joined #vdsm 10:48 -!- tiraboschi_ (purple): has joined #vdsm 11:03 -!- ybronhei: has quit [Read error: No route to host] 11:03 -!- ybronhei (purple): has joined #vdsm 11:07 -!- ybronhei: has quit [Ping timeout: 260 seconds] 11:08 -!- ishaby: has quit [Ping timeout: 272 seconds] 11:33 -!- phoracek (phoracek): has joined #vdsm 11:34 -!- #vdsm YifanZeng: has quit [Quit: Leaving] 12:20 -!- ishaby (Idan Shaby): has joined #vdsm 13:28 -!- ishaby: has quit [Ping timeout: 276 seconds] 13:31 -!- irit: has quit [Ping timeout: 264 seconds] 13:55 -!- rmohr: has quit [Ping timeout: 240 seconds] 13:55 -!- rmohr (Roman Mohr): has joined #vdsm 14:01 -!- ishaby (Idan Shaby): has joined #vdsm 14:06 -!- phbailey (Phillip Bailey): has joined #vdsm 14:10 -!- ishaby: has quit [Ping timeout: 244 seconds] 14:55 -!- alitke (Adam Litke): has joined #vdsm 14:55 -!- rmatinata (Ricardo Marin Matinata): has joined #vdsm 15:00 -!- nsoffer (Nir Soffer): has joined #vdsm 15:09 -!- ishaby (Idan Shaby): has joined #vdsm 15:23 -!- ishaby: has quit [Ping timeout: 252 seconds] 15:27 -!- ishaby (Idan Shaby): has joined #vdsm 15:33 -!- fromani: has quit [Ping timeout: 246 seconds] 15:34 -!- fromani (Francesco Romani): has joined #vdsm 15:37 -!- fromani: has quit [Client Quit] 15:38 -!- fromani (Francesco Romani): has joined #vdsm 15:49 < alitke> nsoffer, Can you help me commit https://gerrit.ovirt.org/#/c/60408/1 quickly? It's a simple, yet embarrassing units bug in storagetestlib 15:49 < nsoffer> alitke, looking 15:59 < nsoffer> alitke, why not change "size_mb = 1 * MB" to "size_mb = 1"? 16:00 < alitke> in the lib or the test? 16:06 -!- rmohr: has quit [Remote host closed the connection] 16:06 -!- rmohr (Roman Mohr): has joined #vdsm 16:11 < nsoffer> alitke, see my comments in the patch 16:11 < alitke> yep. Will address and resubmit 16:12 < nsoffer> alitke, this is not the first time we make these errors, I wonder how we can eliminate these 16:12 < alitke> Hire a better programmer :-/ 16:13 < nsoffer> alitke, a better type system can help 16:13 < alitke> We had a test for it but the test was wrong. 16:13 < nsoffer> alitke, did you write the test before the code or after? 16:14 < alitke> For that test I think we expanded it when changing the underlying implementation 16:14 < alitke> we used to not create a fake file for io to the LV 16:14 < alitke> This may have been added at that time. 16:21 -!- jbrooks: has quit [Remote host closed the connection] 16:22 < nsoffer> alitke, can you add (in another patch) test for unaligned size? 16:22 < alitke> ok 16:22 < nsoffer> maybe using permutations? 16:23 < nsoffer> alitke, but wait 16:24 < nsoffer> alitke, make_block_volume takes size in bytes? 16:24 < alitke> yes 16:24 < alitke> just like make_file_volume 16:24 < alitke> We want to converge the API so we can permutate tests for file and block envs 16:24 < nsoffer> alitke, but in the test you call it with size_mb 16:24 < nsoffer> make_block_volume(env.lvm, env.sd_manifest, size_mb, 16:25 < nsoffer> alitke, the test may pass because of rounding :-) 16:25 < alitke> ahh, yes. That's it. 16:25 < alitke> need to fix the test again :( 16:26 -!- irit (purple): has joined #vdsm 16:26 < alitke> nsoffer, so I guess size_bytes in the test will make it clearer :) 16:27 < nsoffer> alitke, "size" should be always bytes 16:27 < nsoffer> alitke, this should be the only unit we use 16:27 < nsoffer> alitke, all the syscalls work with bytes 16:28 < nsoffer> size_mb size_blk can be used for the few cases we don't work with bytes 16:29 < alitke> updated 16:32 < nsoffer> alitke, see new comment 16:32 < nsoffer> alitke, why aren't we testing the lv size in this test? is it tested in other tests? 16:32 < alitke> heh. Nothing is ever quick. 16:33 < nsoffer> alitke, that was too quick, missing other code 16:36 -!- mskrivanek is now known as mskrivanek_away 16:55 -!- pkliczew: has quit [Remote host closed the connection] 17:13 -!- irit: has quit [Ping timeout: 244 seconds] 17:15 < nsoffer> alitke, ping me when the patch is ready, I will be online later today 17:16 < alitke> nsoffer, Yeah. I am testing. Found another problem. lvm rounds to 128m granularity (not 1 MB) 17:16 < alitke> fixing it altogether with a permutated test included. 17:17 < nsoffer> alitke, lvm rounds to extent size, we have a constant for this 17:18 < alitke> yep 17:18 < alitke> I will post the updated patch now. 17:19 < alitke> nsoffer, see update. 17:22 -!- nsoffer: has quit [Ping timeout: 252 seconds] 17:26 -!- phoracek: has quit [Quit: WeeChat 1.4] 17:27 -!- sbonazzo: has quit [Quit: Leaving.] 17:41 -!- tim: has quit [Ping timeout: 276 seconds] 17:42 -!- ndarshan: has quit [Quit: Leaving] 17:48 -!- irit (purple): has joined #vdsm 17:51 -!- ybronhei (purple): has joined #vdsm 17:58 -!- tiraboschi_: has left #vdsm ["PING 1467993496"] 18:00 -!- fromani: has quit [Quit: Leaving] 18:24 -!- hchiramm: has quit [Ping timeout: 250 seconds] 18:48 -!- ybronhei: has quit [Ping timeout: 264 seconds] 19:05 -!- ybronhei (purple): has joined #vdsm 19:07 -!- ishaby: has quit [Ping timeout: 264 seconds] 19:17 -!- ybronhei: has quit [Ping timeout: 244 seconds] 19:34 -!- ybronhei (purple): has joined #vdsm 20:47 -!- nsoffer (Nir Soffer): has joined #vdsm 21:02 -!- ybronhei: has quit [Ping timeout: 240 seconds] 21:09 -!- ybronhei (purple): has joined #vdsm 21:16 -!- irit: has quit [Ping timeout: 260 seconds] 21:31 -!- ybronhei: has quit [Ping timeout: 258 seconds] 21:33 < nsoffer> alitke, ping 21:56 -!- nsoffer: has quit [Quit: Segmentation fault (core dumped)] 21:56 -!- nsoffer (Nir Soffer): has joined #vdsm 22:05 -!- rmatinata: has quit [Quit: This computer has gone to sleep] 22:47 -!- tiraboschi_ (purple): has joined #vdsm 22:47 -!- tiraboschi_: has quit [Client Quit] 22:47 -!- tiraboschi_ (purple): has joined #vdsm 22:48 -!- tiraboschi_: has quit [Client Quit] 22:48 -!- tiraboschi_ (purple): has joined #vdsm 22:55 -!- ahino: has quit [Ping timeout: 276 seconds] 23:09 -!- ahino (purple): has joined #vdsm 23:41 -!- tiraboschi_: has quit [Ping timeout: 260 seconds] --- Log closed za jul 09 00:00:54 2016