--- Log opened do jun 16 00:00:09 2016 00:31 -!- ybronhei: has quit [Ping timeout: 240 seconds] 00:51 -!- nsoffer_: has quit [Ping timeout: 276 seconds] 01:09 -!- fsimonce: has quit [Quit: Coyote finally caught me] 01:16 -!- adahms (Andrew Dahms): has joined #vdsm 01:47 -!- ybronhei (purple): has joined #vdsm 01:51 -!- ybronhei: has quit [Ping timeout: 258 seconds] 03:42 -!- #vdsm dyasny: has quit [Ping timeout: 244 seconds] 05:47 -!- rmohr (Roman Mohr): has joined #vdsm 05:59 -!- shubhendu (Shubhendu): has joined #vdsm 06:00 -!- derez_ (Daniel Erez): has joined #vdsm 06:29 -!- rmohr: has quit [Quit: rmohr] 07:08 -!- ishaby (Idan Shaby): has joined #vdsm 07:14 -!- tim__ (Tim): has joined #vdsm 07:17 -!- ndarshan (Darshan n): has joined #vdsm 07:35 -!- adahms: has quit [Ping timeout: 260 seconds] 07:35 -!- edwardh (purple): has joined #vdsm 07:40 -!- Humble: has quit [Ping timeout: 244 seconds] 07:43 -!- fabiand (Fabian Deutsch): has joined #vdsm 07:57 -!- mmirecki (Marcin Mirecki): has joined #vdsm 07:59 -!- rmohr (Roman Mohr): has joined #vdsm 08:08 -!- Humble (hchiramm): has joined #vdsm 08:09 -!- nsoffer_ (Nir Soffer): has joined #vdsm 08:14 -!- Humble: has quit [Ping timeout: 272 seconds] 08:18 -!- nsoffer_: has quit [Quit: Segmentation fault (core dumped)] 08:19 -!- nsoffer (Nir Soffer): has joined #vdsm 08:22 -!- fromani (Francesco Romani): has joined #vdsm 08:34 -!- mzamazal (Milan Zamazal): has joined #vdsm 08:45 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 08:47 -!- ndarshan: has quit [Ping timeout: 246 seconds] 08:50 -!- apahim (Amador Pahim): has joined #vdsm 08:52 -!- Humble (hchiramm): has joined #vdsm 08:55 -!- ndarshan (Darshan n): has joined #vdsm 08:55 -!- mode/#vdsm: by ChanServ 08:55 -!- danken (purple): has joined #vdsm 09:10 < nsoffer> apuimedo, ping 09:22 -!- ybronhei (purple): has joined #vdsm 09:28 -!- fsimonce (Federico): has joined #vdsm 10:06 < mpolednik> anyone here actually installed ovirt-release-master /for vdsm/ on el7 server host recently? the centos repo requires $releasever == 7; rhel has 7Server 10:07 < mpolednik> probably danken ^^ ? 10:13 -!- ybronhei: has quit [Ping timeout: 258 seconds] 10:15 < nsoffer> mpolednik, I install it on rhel 7.2, no issues 10:17 < nsoffer> mpolednik, trying again now 10:18 < nsoffer> mpolednik, ovirt-release-master-4.0.0-0.5.master.20160614090513.git7fe7b5b 10:19 < mzamazal> apuimedo: Did my response to your comments in https://gerrit.ovirt.org/58833 answer your worries? 10:20 < mpolednik> nsoffer: is your el the "server" version? the way repo is used ($releasever) can't work at all if 7Server is the version 10:23 -!- mmirecki is now known as mmirecki_brb 10:26 -!- ndarshan: has quit [Ping timeout: 246 seconds] 10:28 -!- ybronhei (purple): has joined #vdsm 10:29 < pkliczew> danken, hi 10:40 -!- ndarshan (Darshan n): has joined #vdsm 10:45 -!- mmirecki_brb is now known as mmirecki 11:28 < apuimedo> nsoffer: pong 11:28 < apuimedo> I did not see it yet 11:29 < apuimedo> let me check mzamazal 11:29 < apuimedo> and dobré dopoledne 11:29 < nsoffer> apuimedo, we would be happy to merge that patch soon 11:29 < mzamazal> apuimedo: Dobré dopoledne! :) 11:30 < apuimedo> ok 11:30 < apuimedo> I'll switch the vote 11:30 < apuimedo> :P 11:30 < mzamazal> apuimedo: Thanks! 11:30 < nsoffer> mzamazal, apuimedo why do you say בוקר טוב? 11:31 < apuimedo> no, no, nsoffer. I'm saying good before noon 11:31 < apuimedo> not good morning 11:31 < apuimedo> boker tov is for all the morning right? 11:32 < nsoffer> apuimedo, google translate did not notice this :-) 11:32 < nsoffer> apuimedo, we don't have sub-morning greetings 11:32 < apuimedo> nsoffer: that's the subtleties of the Czech language ;-) 11:32 < apuimedo> we split the time in a lot of fractions 11:32 < apuimedo> :P 11:33 < apuimedo> Catalan though, like french, just has Bon dia (Bonjour) until nightfall 11:35 < nsoffer> apuimedo, thanks 11:35 < nsoffer> mzamazal, seems that we need a rebase now on https://gerrit.ovirt.org/#/c/58833/ 11:36 < mzamazal> nsoffer: yes, I'll do it. 11:44 < apuimedo> danken: did you see my gargantuan contribution to vdsm from last night? 11:44 < apuimedo> https://gerrit.ovirt.org/#/c/59255/ 11:44 < apuimedo> xD 11:48 -!- mmirecki is now known as mmirecki_brb 11:50 -!- ishaby: has quit [Ping timeout: 264 seconds] 12:03 < nsoffer> pkliczew, do you want to ack https://gerrit.ovirt.org/#/c/58833 after the rebase? 12:04 -!- rmohr: has quit [Ping timeout: 240 seconds] 12:04 < pkliczew> nsoffer, looking 12:05 < pkliczew> nsoffer, done 12:07 < nsoffer> pkliczew, thanks, did you see michal comment on https://gerrit.ovirt.org/#/c/58465? 12:08 < pkliczew> nsoffer, looking now 12:08 < nsoffer> pkliczew, also check my comment here: https://gerrit.ovirt.org/#/c/58465/14/vdsm/API.py@1204 12:12 < pkliczew> nsoffer, I replied 12:13 < pkliczew> nsoffer, we went this path before and I think it is not good idea to do it again 12:14 -!- bazulay (purple): has joined #vdsm 12:14 < nsoffer> pkliczew, I don't remember that we did something similar in the past 12:15 -!- phoracek (phoracek): has joined #vdsm 12:15 < pkliczew> nsoffer, I mean in principal we had bunch of additional logic in xmlrpc binding which should have been part of verb implementation 12:15 < nsoffer> pkliczew, you mean wrapping of the response? 12:16 < pkliczew> nsoffer, I am thinking about removing api.py in the future, it is long way to go but we could do it 12:16 < nsoffer> pkliczew, I agree, we should kill this layer 12:16 < pkliczew> nsoffer, so if there is any custom logic there we would need to move it 12:16 < nsoffer> pkliczew, but this is where we need to wrap the response with the current code 12:16 < pkliczew> nsoffer, exactly, it is not needed 12:16 < nsoffer> pkliczew, and we want to backport it to 4.0 12:16 < nsoffer> mzamazal, right? 12:17 < mzamazal> nsoffer: right 12:17 < nsoffer> pkliczew, so we can move the implementation there to some other module, which will be the new entry point 12:18 < nsoffer> pkliczew, but only on master, and after we get this in to make the backport easier and less risky 12:18 < pkliczew> nsoffer, I still need to think about the details but ideally yes 12:18 < pkliczew> nsoffer, in terms of logging my opinion is to do it just before the response is sent 12:19 < pkliczew> nsoffer, so master and backports should be very similar 12:19 < nsoffer> pkliczew, we want to log some methods only periodically 12:20 -!- derez_: has quit [Quit: Leaving] 12:20 < nsoffer> pkliczew, how can you do this from the jsonrpc server layer? it does not have any context about this log 12:20 < pkliczew> nsoffer, I agree but let's do it in one place for all of them and not for specific verbs 12:20 -!- derez_ (Daniel Erez): has joined #vdsm 12:21 < nsoffer> pkliczew, mzamazal what if we log everything from the server layer via periodic logger? 12:21 < pkliczew> nsoffer, in jsonrpc the common place would be the bridge 12:21 < nsoffer> verbs without any configuration will log every call, and some versb can log less 12:21 < nsoffer> pkliczew, I want to kill the bridge :-) 12:22 < pkliczew> nsoffer, yeah, bridge and api should be removed :) 12:22 < nsoffer> pkliczew, all the special treatment is horrible (for verb x, take output y) 12:22 < nsoffer> pkliczew, verbs should return a value, and server layer should send it out 12:22 < pkliczew> nsoffer, agree but on the other hand it needs to be done somewhere 12:23 < nsoffer> pkliczew, one we kill xmlprc, we can simplify all this 12:23 < pkliczew> nsoffer, sure, I would be more than happy to do it :) 12:23 < nsoffer> now, about xmlprc, we forgot about the ovf read/write, abusing xmlrpc server 12:23 < nsoffer> pkliczew, so we cannot disable it now 12:24 < pkliczew> nsoffer, agree, do you want me to keep the patch in gerrit for now? 12:24 < nsoffer> pkliczew, we stop registering the xmlprc function with the server 12:25 < pkliczew> nsoffer, when your http server work would be ready for usage? 12:25 < nsoffer> pkliczew, as is we cannot use it, if you disable only the point when we register the functions, we can use it soon hopefully 12:25 < nsoffer> pkliczew, it is ready, but we need to change engine code to use it 12:25 < pkliczew> nsoffer, cool so let's sync disabling and your http server work so we have nice replacement 12:26 < nsoffer> and old engine will still use the old code path 12:26 < pkliczew> :/ 12:26 < nsoffer> so if we fix engine in 4.1, we can remove it in 4.2, since engine 4.0 still use the old http upload/download 12:26 < nsoffer> pkliczew, fun :-) 12:27 < pkliczew> what about doing small change to keep http detection and stop using rpc? 12:27 < pkliczew> maybe we could even forward the http call to the new server 12:28 < nsoffer> pkliczew, possible, currently we use GET and PUT for http, and POST for xmlrpc 12:28 < pkliczew> nsoffer, with not a lot of work we could use only GET and PUT 12:28 < nsoffer> pkliczew, the call is totally different, we cannot forward it 12:28 < pkliczew> nsoffer, ok 12:29 < mzamazal> nsoffer: We want to log every call, but for some verbs without full data (full data only occasionally). 12:29 < nsoffer> mzamazal, so we can change the logs in the server layer to use the periodic logger 12:29 < nsoffer> will log every call with the right amount of data 12:30 < nsoffer> mzamazal, single place for controlling rpc layer logging 12:30 < mzamazal> nsoffer: That's one possible solution. 12:30 < nsoffer> mzamazal, so instead of adding "logger", you add options for some verbs 12:30 < nsoffer> add_restriction? 12:31 < nsoffer> priodiclog.throttle("getAllVmStats", interval=50, timeout=300) 12:31 < nsoffer> mzamazal, ^^^ 12:32 < nsoffer> mzamazal, without the typos probably 12:33 < mzamazal> nsoffer: May be a good idea. You mean using then periodiclog.log(verb, "Calling in bridge ...", ...)? 12:34 < mzamazal> nsoffer: BTW, we want to suppress parameters of some verbs in rpc logging, maybe we could use a similar mechanism, would be good. 12:36 -!- nsoffer: has quit [Ping timeout: 272 seconds] 12:45 -!- saggi (purple): has joined #vdsm 13:11 -!- mmirecki_brb is now known as mmirecki 13:14 -!- nsoffer (Nir Soffer): has joined #vdsm 13:23 -!- ishaby (Idan Shaby): has joined #vdsm 13:37 <@danken> apuimedo: I think that I've seen it before... 13:37 <@danken> apuimedo: but thanks! 13:47 -!- ybronhei: has quit [Quit: Leaving.] 13:51 -!- rmohr (Roman Mohr): has joined #vdsm 13:54 -!- msivak_ (Martin Sivak): has joined #vdsm 13:54 -!- ybronhei (purple): has joined #vdsm 14:02 -!- apahim: has quit [Ping timeout: 240 seconds] 14:12 -!- rmohr: has quit [Ping timeout: 244 seconds] 14:17 -!- apahim (Amador Pahim): has joined #vdsm 14:25 -!- ndarshan: has quit [Quit: Leaving] 14:35 < apuimedo> ;-) 14:56 -!- alitke (Adam Litke): has joined #vdsm 15:01 < nsoffer> fromani, pkliczew can ack again https://gerrit.ovirt.org/59019 (fixed typos) 15:01 < pkliczew> nsoffer, checking 15:02 < fromani> nsoffer: done, not sure it was worth a resubmit 15:03 < nsoffer> fromani, you comment produded it 15:03 < fromani> nsoffer: fair enough 15:08 -!- rmatinata (Ricardo Marin Matinata): has joined #vdsm 15:16 -!- saggi1 (purple): has joined #vdsm 15:21 -!- tim__: has quit [Ping timeout: 272 seconds] 15:31 -!- pkliczew: has quit [Remote host closed the connection] 15:34 -!- saggi1: has quit [Ping timeout: 246 seconds] 15:38 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 15:40 -!- Humble: has quit [Ping timeout: 260 seconds] 15:42 -!- dyasny (Dan Yasny): has joined #vdsm 15:51 -!- saggi1 (purple): has joined #vdsm 15:53 -!- edwardh: has quit [Ping timeout: 246 seconds] 15:54 -!- saggi1: has quit [Client Quit] 16:15 -!- shubhendu: has quit [Ping timeout: 252 seconds] 16:30 -!- apahim: has quit [Ping timeout: 272 seconds] 16:44 -!- apahim (Amador Pahim): has joined #vdsm 17:09 -!- nsoffer: has quit [Ping timeout: 264 seconds] 17:21 -!- saggi: has quit [Ping timeout: 240 seconds] 17:26 -!- fromani is now known as fromani|afk 17:32 -!- pkliczew: has quit [Ping timeout: 240 seconds] 17:37 -!- saggi (purple): has joined #vdsm 17:39 -!- mskrivanek is now known as mskrivanek_away 17:41 -!- amarchuk: has quit [Quit: Leaving] 17:54 -!- jbrooks (Jason Brooks): has joined #vdsm 18:18 -!- jbrooks: has quit [Quit: Ex-Chat] 18:21 -!- mzamazal: has quit [Remote host closed the connection] 19:22 -!- tim__ (Tim): has joined #vdsm 19:40 -!- derez_: has quit [Quit: Leaving] 19:59 -!- bazulay: has quit [Quit: Leaving.] 20:35 -!- shubhendu (Shubhendu): has joined #vdsm 21:24 -!- ybronhei: has quit [Ping timeout: 252 seconds] 21:26 -!- fabiand: has quit [Quit: Verlassend] 21:36 -!- phoracek: has quit [Quit: WeeChat 1.4] 21:40 -!- fabiand (Fabian Deutsch): has joined #vdsm 21:46 -!- tim__: has quit [Ping timeout: 252 seconds] 22:05 -!- fabiand: has quit [Quit: Verlassend] 22:27 -!- phbailey: has quit [Ping timeout: 244 seconds] 22:29 -!- ybronhei (purple): has joined #vdsm 22:33 -!- rmatinata: has quit [Quit: This computer has gone to sleep] 22:39 -!- phbailey (Phillip Bailey): has joined #vdsm 22:51 -!- shubhendu: has quit [Ping timeout: 246 seconds] 23:06 -!- mmirecki: has quit [Ping timeout: 250 seconds] 23:47 -!- msivak_: has quit [Quit: msivak_] --- Log closed vr jun 17 00:00:11 2016