--- Log opened wo nov 11 00:00:34 2015 00:45 -!- bazulay (purple): has joined #vdsm 01:53 -!- bazulay: has quit [Ping timeout: 250 seconds] 02:16 -!- rmatinata (Ricardo Marin Matinata): has joined #vdsm 02:51 -!- vxitch: has quit [Ping timeout: 250 seconds] 03:06 -!- nsoffer: has quit [Ping timeout: 276 seconds] 03:09 -!- vxitch (Unknown): has joined #vdsm 03:32 -!- adahms: has quit [Max SendQ exceeded] 06:21 -!- gpadgett: has quit [Quit: Leaving] 07:07 -!- ishaby (Idan Shaby): has joined #vdsm 07:14 -!- acanan (Aharon Canan): has joined #vdsm 07:18 -!- oved (ovedo): has joined #vdsm 07:21 -!- acanan: has quit [Quit: Leaving] 07:21 -!- acanan (Aharon Canan): has joined #vdsm 07:29 -!- ybronhei (purple): has joined #vdsm 07:35 -!- sbonazzo (purple): has joined #vdsm 07:52 -!- ahino: has quit [Ping timeout: 252 seconds] 08:04 -!- acanan: has quit [Remote host closed the connection] 08:18 -!- fabiand (Fabian Deutsch): has joined #vdsm 08:22 -!- rmohr (Roman Mohr): has joined #vdsm 08:28 -!- rmohr: has quit [Ping timeout: 250 seconds] 08:44 -!- #vdsm ybronhei: has quit [Ping timeout: 260 seconds] 08:54 -!- fromani (Francesco Romani): has joined #vdsm 08:59 -!- ykaplan (Yeela Kaplan): has joined #vdsm 09:27 -!- tiraboschi_: has left #vdsm [] 09:32 -!- mmirecki-afk (Marcin Mirecki): has joined #vdsm 09:34 -!- acanan (Aharon Canan): has joined #vdsm 09:44 -!- ahino (purple): has joined #vdsm 09:50 -!- sshnaidm (Sergey (Sagi) Shnaidman): has joined #vdsm 10:00 -!- oved: has quit [Ping timeout: 252 seconds] 10:10 -!- ishaby: has quit [Ping timeout: 264 seconds] 10:11 -!- derez_ (Daniel Erez): has joined #vdsm 10:12 -!- bala (purple): has joined #vdsm 10:13 -!- oved (ovedo): has joined #vdsm 10:17 -!- bala: has quit [Ping timeout: 240 seconds] 10:23 -!- mmirecki-afk is now known as mmirecki 10:26 -!- ishaby (Idan Shaby): has joined #vdsm 11:02 -!- ybronhei (purple): has joined #vdsm 11:06 -!- #vdsm ybronhei: has quit [Ping timeout: 250 seconds] 11:19 -!- ishaby: has quit [Ping timeout: 260 seconds] 11:23 -!- ybronhei (purple): has joined #vdsm 11:25 -!- oved: has quit [Ping timeout: 260 seconds] 11:32 -!- ishaby (Idan Shaby): has joined #vdsm 11:38 -!- oved (ovedo): has joined #vdsm 11:40 -!- nsoffer (Nir Soffer): has joined #vdsm 11:41 -!- mode/#vdsm: by ChanServ 11:41 -!- danken1 (purple): has joined #vdsm 11:44 -!- firemanxbr (Marcelo Barbosa): has joined #vdsm 11:58 -!- ykaplan: has quit [Ping timeout: 240 seconds] 12:11 < nsoffer> ybronhei, ping 12:39 -!- adahms (Andrew Dahms): has joined #vdsm 12:39 -!- danken1: has quit [Ping timeout: 260 seconds] 12:45 -!- ykaplan (Yeela Kaplan): has joined #vdsm 12:48 -!- #vdsm ybronhei: has quit [Ping timeout: 252 seconds] 12:49 < sbonazzo> fromani: can you please review / merge https://gerrit.ovirt.org/48408 ? 12:51 < fromani> sbonazzo: sure, queued 12:54 -!- mode/#vdsm: by ChanServ 12:54 -!- danken1 (purple): has joined #vdsm 12:59 < sbonazzo> fromani: do you still need this? http://jenkins.ovirt.org/user/sbonazzo/my-views/view/Disabled/job/vdsm_master_unit_tests_fromani/ 13:00 < fromani> sbonazzo: I think we don't. 13:00 < sbonazzo> danken1: hi, can you please review / merge https://gerrit.ovirt.org/48408 ? 13:00 < sbonazzo> fromani: ok, dropping 13:01 -!- ybronhei (purple): has joined #vdsm 13:02 < ybronhei> nsoffer: hi 13:02 < ybronhei> nsoffer: are you at office? 13:06 -!- nsoffer: has quit [Ping timeout: 250 seconds] 13:28 -!- sshnaidm: has quit [Ping timeout: 276 seconds] 13:32 < fromani> danken1: I'm going to merge https://gerrit.ovirt.org/#/c/48348 soon if there aren't objections 13:37 <@danken1> fromani: none from me 13:39 <@danken1> sbonazzo: why would we want the explicit list if you generate it automatically? 13:42 < sbonazzo> danken1: I haven't spent too much time digging on the dep tree, this one just solve the build issues related to missing deps. We can keep jenkins failing while we cleanup the deps if you think it has to be done in this patch :-) 13:43 -!- sshnaidm (Sergey (Sagi) Shnaidman): has joined #vdsm 13:52 <@danken1> sbonazzo: that would be more pure... but I suppose a cleanup patch can wait. coincidently I've posted https://gerrit.ovirt.org/#/c/48230/ recently. more cleanup should happen 13:53 < sbonazzo> danken1: ok 13:56 -!- mmirecki: has quit [Ping timeout: 255 seconds] 13:59 -!- saggi is now known as saggi_2 13:59 -!- saggi_2 is now known as saggi 14:20 -!- danken1: has quit [Ping timeout: 240 seconds] 14:25 -!- derez__ (Daniel Erez): has joined #vdsm 14:25 -!- derez_: has quit [Ping timeout: 252 seconds] 14:27 -!- oved: has quit [Ping timeout: 276 seconds] 14:31 -!- #vdsm ybronhei: has quit [Ping timeout: 246 seconds] 14:35 -!- rmohr (Roman Mohr): has joined #vdsm 14:41 -!- mode/#vdsm: by ChanServ 14:41 -!- danken1 (purple): has joined #vdsm 14:41 -!- oved (ovedo): has joined #vdsm 14:42 -!- msivak (Martin Sivak): has joined #vdsm 14:43 < fromani> danken1: https://gerrit.ovirt.org/#/c/48191/ should be ready now 14:45 -!- sshnaidm: has quit [Ping timeout: 276 seconds] 14:48 -!- ybronhei (purple): has joined #vdsm 14:50 -!- phoracek (phoracek): has joined #vdsm 15:07 -!- ishaby: has quit [Ping timeout: 255 seconds] 15:08 -!- Netsplit *.net <-> *.split quits: msivak 15:14 -!- oved: has quit [Ping timeout: 264 seconds] 15:15 -!- sshnaidm (Sergey (Sagi) Shnaidman): has joined #vdsm 15:15 -!- msivak (Martin Sivak): has joined #vdsm 15:16 -!- sshnaidm: has quit [Changing host] 15:16 -!- sshnaidm (Sergey (Sagi) Shnaidman): has joined #vdsm 15:16 -!- ishaby (Idan Shaby): has joined #vdsm 15:18 -!- #vdsm ybronhei: has quit [Quit: Leaving.] 15:21 -!- derez__: has quit [Ping timeout: 240 seconds] 15:26 -!- nsoffer (Nir Soffer): has joined #vdsm 15:26 -!- adahms: has quit [Quit: Leaving] 15:28 -!- danken1: has quit [Quit: Leaving.] 15:35 -!- derez__ (Daniel Erez): has joined #vdsm 15:51 -!- acanan: has quit [Quit: Leaving] 16:01 -!- mode/#vdsm: by ChanServ 16:01 -!- danken1 (purple): has joined #vdsm 16:29 -!- ishaby: has quit [Ping timeout: 265 seconds] 16:55 -!- ybronhei1 (purple): has joined #vdsm 17:06 -!- sshnaidm: has quit [Ping timeout: 276 seconds] 17:11 -!- phoracek: has quit [Quit: WeeChat 1.2] 17:18 -!- ahino: has quit [Ping timeout: 240 seconds] 17:31 -!- gpadgett (Greg Padgett): has joined #vdsm 17:35 -!- ykaplan: has quit [Remote host closed the connection] 17:41 -!- phoracek (phoracek): has joined #vdsm 17:43 -!- #vdsm ybronhei1: has quit [Ping timeout: 260 seconds] 17:56 -!- phoracek: has quit [Quit: WeeChat 1.2] 18:02 -!- bazulay (purple): has joined #vdsm 18:04 -!- sbonazzo: has quit [Quit: Leaving.] 18:15 -!- danken1: has quit [Quit: Leaving.] 18:16 -!- fromani: has quit [Remote host closed the connection] 18:28 -!- rmohr: has quit [Ping timeout: 240 seconds] 18:40 -!- derez__: has quit [Quit: Leaving] 18:47 -!- mode/#vdsm: by ChanServ 18:47 -!- danken1 (purple): has joined #vdsm 18:49 -!- danken1: has quit [Client Quit] 19:56 -!- ahino (purple): has joined #vdsm 20:35 -!- firemanxbr: has quit [Quit: Leaving] 21:03 -!- nsoffer: has quit [Ping timeout: 244 seconds] 21:04 -!- bazulay: has quit [Read error: Connection reset by peer] 21:04 -!- bazulay (purple): has joined #vdsm 21:08 -!- bazulay: has quit [Ping timeout: 240 seconds] 21:34 -!- nsoffer (Nir Soffer): has joined #vdsm 21:38 -!- nsoffer: has quit [Ping timeout: 252 seconds] 21:44 -!- nsoffer (Nir Soffer): has joined #vdsm 21:51 -!- nsoffer: has quit [Ping timeout: 244 seconds] 21:57 -!- msivak: has quit [Quit: msivak] 22:48 -!- nsoffer (Nir Soffer): has joined #vdsm 23:03 -!- ybronhei (purple): has joined #vdsm 23:08 < nsoffer> ybronhei, hi 23:08 < ybronhei> nsoffer: I read your comments 23:08 < nsoffer> ybronhei, I'm looking now at automate docs 23:09 < ybronhei> nsoffer: both AM_CONDITIONAL and AC_SUBST is not a solution 23:09 < nsoffer> I don't see any other way for gluster_mgmt 23:09 < nsoffer> ybronhei, why it is not a solution? 23:09 < ybronhei> nsoffer: automate docs? 23:09 < nsoffer> automake 23:09 < ybronhei> and? 23:09 < nsoffer> https://www.gnu.org/software/automake/manual/automake.html 23:10 < ybronhei> ok, its quite long :) 23:11 < nsoffer> we can use ac_subst, and add ifeq () in the makefile 23:11 < nsoffer> ybronhei, check https://www.gnu.org/software/automake/manual/automake.html#Conditionals 23:12 < ybronhei> what is ifeq () ? 23:13 < ybronhei> nsoffer: not sure I follow your suggestion .. 23:13 < nsoffer> ybronhei, http://www.gnu.org/software/autoconf/manual/autoconf.html#Setting-Output-Variables 23:14 < nsoffer> instead of enabling/disabling feature in the makefile using automake 23:14 < nsoffer> if VAR 23:14 < nsoffer> ... 23:14 < nsoffer> endif 23:15 < nsoffer> We can use value replaced by autoconf 23:15 < nsoffer> ifeq ("@GLUSTER_MGMT@","yes") 23:15 < nsoffer> ... 23:15 < nsoffer> endif 23:15 < nsoffer> I think it should work 23:16 < nsoffer> so in configure, we use AC_SUBST 23:16 < nsoffer> ybronhei, ^^^ ? 23:16 < ybronhei> i see that 23:17 < ybronhei> i try to understand how its different then the patch we just compose 23:17 < ybronhei> than 23:18 < nsoffer> ybronhei, just small change in the gluster makefile.am 23:18 < nsoffer> keep the configure.ac change 23:19 < ybronhei> I dont see this ifeq 23:19 < nsoffer> ifeq is make syntax 23:19 < nsoffer> here another short manual: http://www.gnu.org/software/make/manual/make.html 23:20 < ybronhei> and the makefile is not makefile.am.in - its not generated 23:20 < ybronhei> running configure won't change @GLUSTER_MGMT@ to anything 23:21 < nsoffer> ybronhei, right, but what you put in .am, go to .in as is 23:21 < nsoffer> and .in go through autoconf 23:22 < ybronhei> ok, I'll try that 23:22 < nsoffer> makefile.am -> automake -> makefile.in -> autoconf -> makefile 23:23 < nsoffer> ybronhei, the best solution is to break gluster package to 2 packages 23:23 < nsoffer> each with its own makefile 23:23 < nsoffer> simple, no magic 23:23 < nsoffer> and also build two packages - vdsm-gluster-client, vdsm-gluster-mgmt 23:24 < ybronhei> it fail to build with ifeq ("@GLUSTER_MGMT@","yes") 23:24 < ybronhei> vdsm/gluster/Makefile.am:42: error: endif without if 23:25 < nsoffer> ybronhei, maybe it fails in automake 23:26 < nsoffer> automake thinks that the endif is end an if block 23:26 < nsoffer> we can probably escape the endif somehow 23:28 < ybronhei> i don't know :\ 23:29 < ybronhei> ill think about it tomorrow .. 23:31 -!- fabiand: has quit [Quit: Verlassend] 23:35 < nsoffer> ybronhei, automate is so ugly 23:35 < nsoffer> ybronhei, here is the sad answer: http://stackoverflow.com/questions/7437116/is-there-a-way-to-tell-automake-not-to-interpret-part-of-the-automakefile 23:36 < ybronhei> yofi :/ 23:36 < ybronhei> ill check it more deeply later 23:38 < nsoffer> are you sure you don't want to add both am_cond and ac_subst? 23:38 < nsoffer> ybronhei, so much simpler 23:42 < nsoffer> ybronhei, and it works: 23:42 < nsoffer> S["GLUSTER_MGMT"]="no" 23:42 < nsoffer> S["GLUSTER_MGMT_FALSE"]="" 23:42 < nsoffer> S["GLUSTER_MGMT_TRUE"]="#" 23:43 < nsoffer> ybronhei, this is what automake wants, we should listen to it --- Log closed do nov 12 00:00:35 2015