--- Log opened vr jun 12 00:00:31 2015 00:04 -!- apuimedo: has quit [Quit: WeeChat 1.2] 00:56 -!- adahms: has quit [Quit: Leaving] 01:15 -!- mpolednik1: has quit [Ping timeout: 252 seconds] 02:09 -!- adahms (Andrew Dahms): has joined #vdsm 03:00 -!- mpolednik1 (mpolednik): has joined #vdsm 03:05 -!- mpolednik1: has quit [Ping timeout: 272 seconds] 03:44 -!- #vdsm dougsland: has quit [Ping timeout: 272 seconds] 03:53 -!- bala (purple): has joined #vdsm 03:56 -!- bala: has quit [Read error: Connection reset by peer] 04:11 -!- bala (purple): has joined #vdsm 04:49 -!- mpolednik1 (mpolednik): has joined #vdsm 04:49 -!- nsoffer: has quit [Ping timeout: 265 seconds] 04:53 -!- mpolednik1: has quit [Ping timeout: 258 seconds] 05:21 -!- gpadgett: has quit [Ping timeout: 276 seconds] 05:58 -!- shubhendu__ (Shubhendu Ram Tripathi): has joined #vdsm 06:33 -!- timothy (Timothy Asir): has joined #vdsm 06:34 -!- timothy is now known as Guest48583 07:23 -!- rmatinata: has quit [Ping timeout: 265 seconds] 07:29 -!- ndarshan (Darshan n): has joined #vdsm 07:35 -!- rmatinata (Ricardo Marin Matinata): has joined #vdsm 07:48 -!- shubhendu__: has quit [Ping timeout: 245 seconds] 07:53 -!- fromani (Francesco Romani): has joined #vdsm 07:56 -!- shubhendu__ (Shubhendu Ram Tripathi): has joined #vdsm 08:12 -!- Madhu_ (Madhu_): has joined #vdsm 08:17 -!- Guest48583: has quit [Ping timeout: 264 seconds] 08:19 -!- sbonazzo (purple): has joined #vdsm 08:26 -!- mpolednik1 (mpolednik): has joined #vdsm 08:31 -!- mpolednik1: has quit [Ping timeout: 264 seconds] 08:35 -!- timothy (Timothy Asir): has joined #vdsm 08:35 -!- timothy is now known as Guest67878 08:37 -!- hchiramm_: has quit [Ping timeout: 272 seconds] 08:38 -!- hchiramm: has quit [Ping timeout: 276 seconds] 08:46 -!- hchiramm (Humble Chirammal): has joined #vdsm 08:54 -!- mskrivanek_away is now known as mskrivanek 09:05 -!- jbrooks: has quit [Ping timeout: 264 seconds] 09:07 -!- adahms: has quit [Quit: Leaving] 09:08 -!- jbrooks (Jason Brooks): has joined #vdsm 09:08 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 09:21 -!- mskrivanek is now known as mskrivanek_away 09:24 -!- mmirecki (Marcin Mirecki): has joined #vdsm 09:38 -!- mskrivanek_away is now known as mskrivanek 09:43 -!- fabiand (Fabian Deutsch): has joined #vdsm 09:54 -!- dkuznets (Dima Kuznetsov): has joined #vdsm 10:01 -!- dkuznets: has quit [Ping timeout: 272 seconds] 10:17 -!- osvoboda (osvoboda): has joined #vdsm 10:28 -!- jbrooks: has quit [Ping timeout: 252 seconds] 10:43 -!- mode/#vdsm: by ChanServ 10:43 -!- danken (purple): has joined #vdsm 10:44 -!- dkuznets (Dima Kuznetsov): has joined #vdsm 10:49 -!- danken: has quit [Ping timeout: 264 seconds] 10:58 -!- mskrivanek is now known as mskrivanek_away 11:03 -!- danken (purple): has joined #vdsm 11:03 -!- mode/#vdsm: by ChanServ 11:08 -!- mskrivanek_away is now known as mskrivanek 11:13 -!- dkuznets: has quit [Ping timeout: 252 seconds] 11:48 -!- mskrivanek is now known as mskrivanek_away 11:51 -!- mskrivanek_away is now known as mskrivanek 11:51 -!- mpolednik (mpolednik): has joined #vdsm 11:52 -!- mpolednik: has quit [Client Quit] 11:52 -!- mpolednik (mpolednik): has joined #vdsm 12:00 -!- osvoboda: has quit [Read error: Connection reset by peer] 12:15 -!- nsoffer (Nir Soffer): has joined #vdsm 12:20 < fromani> looks like today's master's broken: Compiling './vds_bootstrap/deployUtil.py'... 12:20 < fromani> *** File "./vds_bootstrap/deployUtil.py", line 250 12:20 < fromani> print "" 12:54 -!- Madhu_: has quit [Quit: Madhu_] 13:19 -!- shubhendu__: has quit [Ping timeout: 264 seconds] 13:20 < fromani> danken: hi, https://gerrit.ovirt.org/#/c/40549/8 looks good 13:20 < fromani> (+1'd just now) 13:21 -!- dkuznets (Dima Kuznetsov): has joined #vdsm 13:32 -!- shubhendu__ (Shubhendu Ram Tripathi): has joined #vdsm 13:32 <@danken> fromani: ok, I'll take it in. 13:41 -!- danken: has quit [Quit: Leaving.] 13:42 -!- mode/#vdsm: by ChanServ 13:42 -!- danken (purple): has joined #vdsm 14:05 -!- shubhendu__: has quit [Ping timeout: 272 seconds] 14:05 -!- adahms (Andrew Dahms): has joined #vdsm 14:07 -!- dougsland (Douglas): has joined #vdsm 14:16 -!- shubhendu__ (Shubhendu Ram Tripathi): has joined #vdsm 14:39 < pkliczew> danken, new patch sets pushed and verified 14:39 < pkliczew> danken, please take a look 14:41 < pkliczew> fromani, ^^^ 14:41 -!- fabiand: has quit [Ping timeout: 256 seconds] 14:42 < fromani> pkliczew: sure 14:42 < pkliczew> fromani, thank you! 14:45 < fromani> pkliczew: I don't have any more comments about https://gerrit.ovirt.org/#/c/38937/31 14:45 < fromani> (+1'd) 14:45 < pkliczew> fromani, looking 14:46 < fromani> same for https://gerrit.ovirt.org/#/c/40904/21 looks good enough for me 14:47 < pkliczew> fromani, I think that most of the comments was already fixed before 14:47 < pkliczew> great 14:47 < pkliczew> few people already acked those patches before 14:47 < fromani> pkliczew: sure sure, I'm just saying I'm ok with the current state of the patches :) 14:47 < pkliczew> fromani, cool 14:47 < fromani> pkliczew: now you have my ack as well 14:47 < pkliczew> fromani, thank you! 14:48 < fromani> pkliczew: anything else in need of review? 14:48 < pkliczew> fromani, if you want to review engine code 14:48 < pkliczew> fromani, there are few patches there (mostly acked) 14:49 < fromani> pkliczew: ok, will have a look if I get some spare time 14:49 < pkliczew> fromani, sure, https://gerrit.ovirt.org/#/q/topic:events_vm_status+project:ovirt-engine 14:54 -!- fabiand (Fabian Deutsch): has joined #vdsm 15:16 -!- dyasny (Dan Yasny): has joined #vdsm 15:27 < fabiand> danken, hey 15:30 -!- #vdsm dyasny: has quit [Ping timeout: 244 seconds] 16:09 < pkliczew> nsoffer, hi 16:09 < nsoffer> pkliczew, hi 16:09 < pkliczew> nsoffer, please take a look at my comment https://gerrit.ovirt.org/#/c/42206/ 16:10 < fromani> danken: is Host.setLogLevel part of the blessed, guaranteed backward-compatible VDSM API? 16:11 < nsoffer> pkliczew, where does the error come from? 16:11 < nsoffer> pkliczew, reading from fd? 16:11 < pkliczew> nsoffer, yes 16:11 < nsoffer> pkliczew, on which line? 16:12 < pkliczew> nsoffer, I deleted the logs from my test but let me check in BZ 16:13 < pkliczew> nsoffer, http://ur1.ca/mt0tp 16:14 < pkliczew> nsoffer, the steps described in bz reproduce the issue every time 16:16 -!- shubhendu__: has quit [Ping timeout: 276 seconds] 16:17 < nsoffer> pkliczew, right 16:17 < nsoffer> pkliczew, the only think needed (after you backport the patches I mentioned), is to check also SSLError in this line: 16:17 < nsoffer> data = client_socket.recv(self._required_size, socket.MSG_PEEK) 16:18 < nsoffer> pkliczew, there is no point to duplicate fixes we already did and used for few month 16:19 < pkliczew> nsoffer, so why not only to just check for SSLError (it fixes the issue) we do not need to backport other patches to stable branch 16:20 < nsoffer> pkliczew, you can, the minimal fix for this issue is indeed to check also for SSLError 16:20 -!- mpolednik: has quit [Ping timeout: 264 seconds] 16:20 < nsoffer> but the other patch I mentioned fix another real issue, not sure why we did not backported it few month ago 16:21 < nsoffer> pkliczew, but better have first a minimal fix for this bug as you suggest 16:21 < pkliczew> nsoffer, ok 16:22 < nsoffer> pkliczew, do we have the same issue with bultin ssl? raising SSLError instead of socket.error? 16:23 < pkliczew> nsoffer, I am not sure, need to check 16:23 < nsoffer> pkliczew, whats the point in socket like object if it raises unrelated errors? 16:23 < pkliczew> nsoffer, good question 16:24 < pkliczew> nsoffer, it seems that ssl modules uses SSLError as well 16:25 < nsoffer> pkliczew, are they subclass of socket.error, or unrelated? 16:26 < pkliczew> nsoffer, it looks like it is not subclass of socket.error 16:29 < nsoffer> pkliczew, fun :-) 16:30 -!- dkuznets: has quit [Ping timeout: 265 seconds] 16:31 -!- ndarshan: has quit [Quit: Leaving] 16:34 -!- adahms: has quit [Quit: Leaving] 16:49 -!- bala: has quit [Quit: Leaving.] 16:53 -!- jbrooks (Jason Brooks): has joined #vdsm 17:06 <@danken> fromani: not really. no Engine has ever used setLogLevel. and I don't think that anyone else seriously depends on it. why? 17:06 -!- dyasny (Dan Yasny): has joined #vdsm 17:22 < Guest67878> nsoffer, hi! 17:29 -!- pkliczew: has quit [Ping timeout: 250 seconds] 17:37 -!- hchiramm_ (Humble Chirammal): has joined #vdsm 17:38 -!- hchiramm: has quit [Ping timeout: 250 seconds] 17:54 -!- ndarshan (Darshan n): has joined #vdsm 18:04 -!- sbonazzo: has quit [Quit: Leaving.] 18:07 -!- ndarshan: has quit [Ping timeout: 250 seconds] 18:08 -!- nsoffer: has quit [Ping timeout: 256 seconds] 18:12 -!- shubhendu__ (Shubhendu Ram Tripathi): has joined #vdsm 18:17 -!- Guest67878 is now known as Timothy07 18:28 -!- gpadgett (Greg Padgett): has joined #vdsm 18:46 -!- Timothy07: has quit [Ping timeout: 255 seconds] 19:04 -!- alitke: has quit [Quit: Leaving] 19:08 -!- timothy_ (Timothy Asir): has joined #vdsm 19:14 -!- alitke (Adam Litke): has joined #vdsm 19:32 -!- timothy_: has quit [Read error: Connection reset by peer] 19:45 -!- timothy_ (Timothy Asir): has joined #vdsm 20:00 -!- dkuznets (Dima Kuznetsov): has joined #vdsm 20:30 -!- timothy_: has quit [Read error: Connection reset by peer] 20:36 -!- fabiand: has quit [Ping timeout: 265 seconds] 20:37 -!- Madhu_ (Madhu_): has joined #vdsm 20:39 -!- Madhu_: has quit [Client Quit] 20:58 -!- shubhendu__: has quit [Ping timeout: 246 seconds] 21:11 -!- dkuznets: has quit [Ping timeout: 244 seconds] 21:11 -!- fabiand (Fabian Deutsch): has joined #vdsm 21:18 -!- fabiand: has quit [Quit: Verlassend] 21:20 -!- mpolednik (mpolednik): has joined #vdsm 21:24 -!- mpolednik: has quit [Ping timeout: 256 seconds] 21:39 -!- mpolednik (mpolednik): has joined #vdsm 21:39 -!- mpolednik: has quit [Client Quit] 21:46 -!- nsoffer (Nir Soffer): has joined #vdsm 21:56 -!- mskrivanek is now known as mskrivanek_away 22:55 -!- #vdsm dyasny: has quit [Ping timeout: 276 seconds] 23:02 -!- nsoffer: has quit [Ping timeout: 245 seconds] 23:21 -!- fromani: has quit [Quit: Leaving] 23:22 -!- mmirecki: has quit [Ping timeout: 252 seconds] 23:37 -!- nsoffer (Nir Soffer): has joined #vdsm --- Log closed za jun 13 00:00:32 2015