--- Log opened ma mei 18 00:00:13 2015 00:42 -!- adahms (Andrew Dahms): has joined #vdsm 01:06 -!- rmatinata: has quit [Ping timeout: 272 seconds] 01:42 -!- rmatinata (Ricardo Marin Matinata): has joined #vdsm 02:03 -!- nsoffer: has quit [Ping timeout: 265 seconds] 03:41 -!- bazulay (purple): has joined #vdsm 03:53 -!- mpolednik: has quit [Ping timeout: 256 seconds] 04:03 -!- bala (purple): has joined #vdsm 04:11 -!- bala: has quit [Ping timeout: 246 seconds] 04:27 -!- bala (purple): has joined #vdsm 05:20 -!- bala: has quit [Quit: Leaving.] 05:22 -!- shubhendu (Shubhendu Ram Tripathi): has joined #vdsm 05:31 -!- #vdsm dyasny: has quit [Ping timeout: 256 seconds] 05:52 -!- adahms: has quit [Quit: Leaving] 06:03 -!- adahms (Andrew Dahms): has joined #vdsm 06:46 -!- vered (Vered Volansky): has joined #vdsm 06:56 -!- ibarkan (purple): has joined #vdsm 07:06 -!- ndarshan (Darshan n): has joined #vdsm 07:30 -!- acanan (Aharon Canan): has joined #vdsm 07:32 -!- bala (purple): has joined #vdsm 07:45 -!- timothy (Timothy Asir): has joined #vdsm 07:46 -!- timothy is now known as Guest18816 07:50 -!- ishaby (Idan Shaby): has joined #vdsm 07:56 -!- nsoffer (Nir Soffer): has joined #vdsm 08:06 -!- ybronhei (purple): has joined #vdsm 08:07 -!- fromani (Francesco Romani): has joined #vdsm 08:10 -!- sbonazzo (purple): has joined #vdsm 08:12 -!- adahms: has quit [Quit: Leaving] 08:16 -!- hchiramm (Humble Chirammal): has joined #vdsm 08:31 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 08:44 -!- fabiand (Fabian Deutsch): has joined #vdsm 08:52 -!- ykaplan (Yeela Kaplan): has joined #vdsm 08:53 -!- dkuznets (Dima Kuznetsov): has joined #vdsm 08:56 -!- mmirecki (Marcin Mirecki): has joined #vdsm 08:58 -!- sbonazzo is now known as sbonazzo|mtg 09:05 -!- rmatinata: has quit [Ping timeout: 272 seconds] 09:05 -!- rmatinata (Ricardo Marin Matinata): has joined #vdsm 09:06 -!- mskrivanek_away is now known as mskrivanek 09:14 -!- sergsh (Sergey Shnaidman): has joined #vdsm 09:21 -!- sbonazzo|mtg is now known as sbonazzo 09:24 -!- tiraboschi_ (purple): has joined #vdsm 09:26 -!- fsimonce (Federico): has joined #vdsm 09:37 -!- dkuznets: has quit [Ping timeout: 256 seconds] 09:39 -!- msivak (Martin Sivak): has joined #vdsm 09:50 -!- dkuznets (Dima Kuznetsov): has joined #vdsm 09:56 -!- shubhendu is now known as shubhendu|lunch 09:57 -!- mode/#vdsm: by ChanServ 09:57 -!- danken (purple): has joined #vdsm 10:10 -!- bala: has quit [Read error: Connection reset by peer] 10:14 -!- ishaby: has quit [Ping timeout: 264 seconds] 10:25 -!- Madhu_ (Madhu_): has joined #vdsm 10:27 -!- acanan: has quit [Ping timeout: 272 seconds] 10:27 -!- ishaby (Idan Shaby): has joined #vdsm 10:34 -!- ndarshan: has quit [Ping timeout: 272 seconds] 10:36 < nsoffer> fromani, when you have time, please look in https://gerrit.ovirt.org/41049 - I think we can use this for vmdevices 10:37 < fromani> nsoffer: sure! now I'm tinkering with my weekathon item, in order to post an early draft later today 10:37 -!- derez_ (Daniel Erez): has joined #vdsm 10:41 < ibarkan> fromani: I have mostly reviewed your sampling cleanup crusade. 10:42 < fromani> ibarkan: yep, noticed! Thanks for your comments! 10:42 < ibarkan> fromani: np 10:46 -!- ndarshan (Darshan n): has joined #vdsm 10:52 -!- shubhendu|lunch is now known as shubhendu 11:09 < fromani> is current master broken for pyflakes? 11:09 -!- ishaby: has quit [Ping timeout: 245 seconds] 11:11 < evilissimo1> oh geez that's already this week -_-' 11:13 < evilissimo1> nsoffer: just FYI your properties patch needs the license header on top of the properties.py 11:13 -!- nsoffer: has quit [Ping timeout: 276 seconds] 11:13 < evilissimo1> lol good timing :D 11:22 -!- ishaby (Idan Shaby): has joined #vdsm 11:29 -!- ndarshan: has quit [Ping timeout: 258 seconds] 11:30 -!- mmirecki: has quit [Ping timeout: 272 seconds] 11:36 -!- acanan (Aharon Canan): has joined #vdsm 11:43 -!- ndarshan (Darshan n): has joined #vdsm 12:05 -!- mmirecki (Marcin Mirecki): has joined #vdsm 12:10 -!- acanan: has quit [Ping timeout: 252 seconds] 12:11 -!- ykaplan: has quit [Ping timeout: 255 seconds] 12:15 -!- nsoffer (Nir Soffer): has joined #vdsm 12:25 -!- msivak: has quit [Remote host closed the connection] 12:25 <@danken> ndarshan: grrr how did this pass the ci tests?! 12:25 <@danken> https://gerrit.ovirt.org/#/c/40892/5/vdsm/gluster/storagedev.py 12:25 <@danken> pkliczew: ^^^ 12:25 -!- acanan (Aharon Canan): has joined #vdsm 12:26 -!- ykaplan (Yeela Kaplan): has joined #vdsm 12:29 < ndarshan> danken: even I was wondering the same, there is one more pyflakes issue there...tim has sent a patch: https://gerrit.ovirt.org/#/c/41046/1 to fix the same 12:29 <@danken> ndarshan: we need to add the pyflakes job to the CI. could you do this so things like that would not repeat? 12:30 <@danken> please add a `make pyflakes` to the unittest job! 12:30 < ndarshan> danken: sure, but might need some help 12:30 < ndarshan> okay 12:32 <@danken> ndarshan: please ask dcaro/eedri - infra folks 12:32 < ndarshan> danken: okay will do that 12:35 < evilissimo1> danken: I am a bit lost right now about this: 16:23:55 @danken | evilissimo1: why does DomainDescriptor have a "dom" property? I think it was meant to be an implementation detail 12:35 < evilissimo1> that was out of context when you wrote me that on friday? 12:42 < evilissimo1> Anyway, I just checked and I can't recall why we've added it 12:42 < evilissimo1> it might have been to have the parsed XML available like it used to be 13:07 <@danken> ndarshan: but first, can you address Pioter's comment on https://gerrit.ovirt.org/#/c/40206/5/vdsm/gluster/storagedev.py ? 13:08 <@danken> evilissimo1: I've asked because I want to kill minidom usage. 13:08 <@danken> if the dom property is dropped, DomainDescriptor can be easily re-implemented with ElementTree 13:16 <@danken> ndarshan: ERROR: test_parseStorageDevices (gluster_cli_tests.GlusterCliTests) 13:16 <@danken> ---------------------------------------------------------------------- 13:16 <@danken> Traceback (most recent call last): 13:16 <@danken> File "/home/danken/.rpm/BUILD/vdsm-4.17.0.3/tests/gluster_cli_tests.py", line 1116, in test_parseStorageDevices 13:16 <@danken> status = parseStorageDevices(glusterTestData.glusterStorageDevData()) 13:16 <@danken> File "/home/danken/.rpm/BUILD/vdsm-4.17.0.3/vdsm/gluster/storagedev.py", line 92, in _parseDevices 13:16 <@danken> deviceList.append(_getDeviceDict(device, _canCreateBrick(device))) 13:16 <@danken> File "/home/danken/.rpm/BUILD/vdsm-4.17.0.3/vdsm/gluster/storagedev.py", line 82, in _getDeviceDict 13:16 <@danken> dev = udev.get_device(device.sysfsPath) or {} 13:16 <@danken> AttributeError: 'TestStorageDev' object has no attribute 'sysfsPath' 13:17 <@danken> (ahhh, sorry for the spam in channel. but a new unit test was broken by you; I don't know why it was not caught by CI) 13:19 < ndarshan> danken: both are actually Tim's patches...Even I saw this issue and reported it to him.....the fix is : https://gerrit.ovirt.org/#/c/41045/ 13:20 <@danken> ndarshan: yeah, I'm talking to you only because I don't see him on #channel 13:20 <@danken> ndarshan: this patch fixes only the pyflakes issue. 13:20 <@danken> it does not touch the broken unittest 13:21 <@danken> ndarshan: ah, you mean the second patch, reading.... 13:21 < ndarshan> yes 13:22 <@danken> ndarshan: you know why it was not caught?! 13:22 <@danken> 08:28:44 test_parseStorageDevices SKIP: No module named blivet 13:22 < ndarshan> okay !! 13:22 <@danken> you must add blivet to the unit test's yaml. 13:23 < ndarshan> okay 13:23 < fromani> danken: is not (yet!) so easy to get rid of minidom, we still need to do more cleanup and XML isolation before 13:26 -!- bala1 (purple): has joined #vdsm 13:27 -!- mskrivanek is now known as mskrivanek_away 13:31 <@danken> fromani: having a "dom" property does not help the isolation 13:31 < evilissimo1> danken: well from what I can see, this should be ok to remove, it seems to have no other usage 13:31 < fromani> danken: that's true 13:31 < evilissimo1> I might be wrong though 13:32 < evilissimo1> but I couldn't find any usage of it 13:32 < evilissimo1> that's why I am not even sure why we've added that one 13:33 <@danken> evilissimo1: that was MY question, don't make it your own! 13:34 < evilissimo1> lol 13:34 -!- derez_: has quit [Ping timeout: 256 seconds] 13:35 < evilissimo1> the only reason I can see is, that it was meant to be forsight for the future, however I'd be rather for removing it and add functions for other queries which are necessary to the DomainDescriptor (aka proper abstraction) 13:35 < evilissimo1> danken: ^ 13:35 <@danken> exactly. please do. 13:36 < Guest18816> hi pkliczew 13:36 < pkliczew> Guest18816, hi 13:36 < fromani> evilissimo1: danken: I have vague memories that we _used_ .dom attribute back in time, then we changed the client code to not use it anymore. I may be wrong, though. 13:37 < evilissimo1> well that would explain why 13:37 -!- Guest18816: has quit [Quit: Leaving] 13:37 -!- timothy_ (Timothy Asir): has joined #vdsm 13:37 < timothy_> hi pkliczew 13:37 < pkliczew> timothy_, hi 13:37 <@danken> timothy_: I've merged your patch 13:37 <@danken> fixing the unit test 13:38 <@danken> timothy_: but as I told ndarshan, you need to add python-blivet to the yaml of the unit tests 13:38 <@danken> otherwise, this test is skipped in Jenkins 13:38 < timothy_> danken, actually i though of update the patch with one more fix suggested by pkliczew 13:38 < timothy_> danken, sure, i will add it to yaml 13:38 <@danken> timothy_: too late ;-) 13:38 <@danken> please send a new patch for that. 13:38 < timothy_> danken, when i build it, it build the rpm without any issue previously 13:39 < timothy_> sure i will send a new patch 13:39 -!- ishaby: has quit [Read error: Connection reset by peer] 13:41 -!- vered: has quit [Remote host closed the connection] 13:42 < timothy_> danken, is there any repo available for yaml? 13:43 < timothy_> danken, no prob, i will check with eedri 13:47 -!- mmirecki: has quit [Ping timeout: 272 seconds] 13:49 -!- ishaby (Idan Shaby): has joined #vdsm 13:50 -!- derez_ (Daniel Erez): has joined #vdsm 13:52 -!- bala1: has quit [Ping timeout: 250 seconds] 13:58 -!- bala1 (purple): has joined #vdsm 13:59 -!- mskrivanek_away is now known as mskrivanek 13:59 -!- mmirecki (Marcin Mirecki): has joined #vdsm 14:00 -!- sbonazzo is now known as sbonazzo|mtg 14:06 -!- acanan: has quit [Remote host closed the connection] 14:11 -!- Madhu_: has quit [Quit: Madhu_] 14:12 < fabiand> danken, ping 14:12 -!- vered (Vered Volansky): has joined #vdsm 14:15 <@danken> fabiand: ? 14:15 < fabiand> danken, you mentioned there is yet another network not there bug - could you point me to it? 14:16 < fabiand> danken, eedri also mentioned it 14:17 <@danken> fabiand: max covgan say that new installaitons of 3.5.z do not persist netconf 14:17 <@danken> I did not dig into it yet 14:17 <@danken> maybe ibarkan managed to? 14:17 < fabiand> right 14:17 < fabiand> danken, so I assume on a regular host .. 14:18 < ibarkan> danken: fabiand: the bz opened by marina? 14:19 < fabiand> ibarkan, the one reopened? 14:21 -!- vlima (Vitor de Lima): has joined #vdsm 14:22 -!- vlima is now known as vdelima 14:22 < ibarkan> fabiand: https://bugzilla.redhat.com/show_bug.cgi?id=1222139 14:23 < fabiand> ibarkan, thanks 14:23 < fabiand> "network was setup as onboot=no and defrout=no." 14:24 < fabiand> That reminds me that we had something like this before .. 14:29 -!- bala1: has quit [Ping timeout: 250 seconds] 14:32 -!- bala (purple): has joined #vdsm 14:36 -!- mpolednik (mpolednik): has joined #vdsm 14:39 -!- msivak (Martin Sivak): has joined #vdsm 14:40 < msivak> fromani: you hid a nice NUMA landmine for me in the 3.5 branch.. https://gerrit.ovirt.org/#/c/33782/4 is missing there (see https://gerrit.ovirt.org/#/c/41059/) 14:41 < msivak> fromani: and it did not show during the functional check.. just during performance testing :/ 14:44 -!- apahim_ (Amador Pahim): has joined #vdsm 14:45 -!- apahim: has quit [Ping timeout: 244 seconds] 14:46 -!- mpolednik: has quit [Quit: WeeChat 1.0.1] 14:47 -!- mpolednik (mpolednik): has joined #vdsm 14:48 < fromani> msivak: nasty, but I wonder how this managed to sneak under our noses :( 14:48 -!- fabiand: has quit [Ping timeout: 265 seconds] 14:51 < msivak> fromani: because I did not notice that I created the function instead of changing it and the code works even without it.. just slower 14:51 < fromani> msivak: ok so it is "just" a performance regression, right? 14:51 < msivak> fromani: not even a regression :) it is just as slow as it used to be :) 14:52 < fromani> msivak: I guess the bottom line is we (virt) should invest more in crafting better tests :\ 14:52 < msivak> I wonder how to test this though.. because it calls the same methods 14:53 < msivak> it only does it directly instead of through stats.. no test would probably catch it (unless we start writing more sophisticated stats tests) 14:53 -!- acanan (Aharon Canan): has joined #vdsm 14:54 < msivak> and the stats thread really works too.. 14:59 -!- sbonazzo|mtg: has quit [Quit: Leaving.] 14:59 -!- ybronhei: has left #vdsm [] 14:59 -!- ybronhei (purple): has joined #vdsm 15:00 -!- fabiand (Fabian Deutsch): has joined #vdsm 15:04 -!- ishaby: has quit [Ping timeout: 272 seconds] 15:04 -!- nsoffer: has quit [Ping timeout: 250 seconds] 15:05 -!- shubhendu: has quit [Ping timeout: 264 seconds] 15:06 -!- ibarkan: has quit [Ping timeout: 244 seconds] 15:09 -!- vered: has quit [Ping timeout: 240 seconds] 15:17 -!- nsoffer (Nir Soffer): has joined #vdsm 15:18 -!- ishaby (Idan Shaby): has joined #vdsm 15:22 -!- vered (Vered Volansky): has joined #vdsm 15:26 -!- mskrivanek is now known as mskrivanek_away 15:28 < timothy_> hi all 15:28 < timothy_> what is the VDSM Sync call conf code? 15:29 < timothy_> 842-597-3915 ? 15:30 < fromani> do we have a vdsm sync call also on monday? 15:30 < timothy_> sorry, just want to update 15:31 < timothy_> hope there is no change in the conf code 15:31 < timothy_> thank you 15:31 -!- firemanxbr (Marcelo Barbosa): has joined #vdsm 15:34 -!- bala: has quit [Quit: Leaving.] 15:41 <@danken> fromani: ybronhei: please ack my https://gerrit.ovirt.org/#/c/40910/2 - I ache to see more info about the failure 15:41 -!- rmatinata: has quit [Ping timeout: 258 seconds] 15:42 <@danken> timothy_: it is https://redhat.bluejeans.com/35386075901/ and every other Tuesday 15:45 < ybronhei> danken: gave a comment - but I don't really mind if you want to merge it as is 15:55 -!- vered: has quit [Ping timeout: 272 seconds] 15:58 <@danken> ybronhei: the new implementation affects (and should affect) all usages of check_call. 15:58 <@danken> I want stderr EVERYWHERE 16:00 -!- sergsh: has quit [Quit: Leaving] 16:00 -!- sergsh (Sergey (Sagi) Shnaidman): has joined #vdsm 16:00 -!- sergsh: has quit [Client Quit] 16:00 -!- sshnaidm (Sergey (Sagi) Shnaidman): has joined #vdsm 16:16 -!- hchiramm is now known as hchiramm_afk 16:17 -!- nsoffer: has quit [Ping timeout: 245 seconds] 16:30 -!- vered (Vered Volansky): has joined #vdsm 16:30 -!- ishaby: has quit [Ping timeout: 252 seconds] 16:36 < ndarshan> danken: pyflakes checks should be added to 3.5 as well ? 16:47 <@danken> ndarshan: yeah, that would be nice. 16:47 <@danken> ndarshan: but make sure that they pass cleanly, first. 16:48 < ndarshan> okay 16:54 -!- nsoffer (Nir Soffer): has joined #vdsm 16:58 -!- mskrivanek_away is now known as mskrivanek 17:09 -!- jbrooks (Jason Brooks): has joined #vdsm 17:11 -!- ndarshan: has quit [Quit: Leaving] 17:14 -!- dkuznets: has quit [Ping timeout: 256 seconds] 17:25 -!- mmirecki: has quit [Ping timeout: 265 seconds] 17:30 -!- dkuznets (Dima Kuznetsov): has joined #vdsm 17:31 -!- sbonazzo (purple): has joined #vdsm 17:35 -!- pkliczew: has quit [Ping timeout: 264 seconds] 17:36 -!- sbonazzo: has quit [Client Quit] 17:51 -!- acanan: has quit [Ping timeout: 245 seconds] 18:12 -!- mskrivanek is now known as mskrivanek_away 18:12 -!- #vdsm ybronhei: has quit [Ping timeout: 240 seconds] 18:13 -!- vered: has quit [Quit: Leaving] 18:16 -!- dkuznets: has quit [Ping timeout: 244 seconds] 18:18 -!- ykaplan: has quit [Remote host closed the connection] 18:37 -!- hchiramm (Humble Chirammal): has joined #vdsm 19:07 -!- derez_: has quit [Ping timeout: 240 seconds] 19:08 -!- ybronhei (purple): has joined #vdsm 19:12 -!- mmirecki (Marcin Mirecki): has joined #vdsm 19:12 -!- derez_ (Daniel Erez): has joined #vdsm 19:17 -!- Madhu_ (Madhu_): has joined #vdsm 19:23 -!- Madhu_: has quit [Quit: Madhu_] 19:29 -!- nsoffer: has quit [Ping timeout: 264 seconds] 19:30 -!- mpolednik: has quit [Ping timeout: 256 seconds] 19:31 -!- derez_: has quit [Ping timeout: 272 seconds] 19:42 -!- fabiand: has quit [Quit: Verlassend] 19:57 -!- derez_ (Daniel Erez): has joined #vdsm 20:05 -!- apahim_: has quit [Remote host closed the connection] 20:09 -!- apahim (Amador Pahim): has joined #vdsm 20:11 -!- sshnaidm: has quit [Ping timeout: 276 seconds] 20:17 -!- vdelima: has quit [Ping timeout: 250 seconds] 20:19 -!- derez_: has quit [Ping timeout: 272 seconds] 20:20 -!- #vdsm hchiramm: has quit [Ping timeout: 264 seconds] 20:27 -!- vlima (Vitor de Lima): has joined #vdsm 20:29 < timothy_> danken, thank you 20:29 -!- Madhu_ (Madhu_): has joined #vdsm 20:32 -!- hchiramm (Humble Chirammal): has joined #vdsm 20:35 -!- timothy_: has quit [Quit: Leaving] 20:41 -!- Madhu_: has quit [Quit: Madhu_] 20:47 -!- #vdsm ybronhei: has quit [Ping timeout: 258 seconds] 20:47 -!- ybronhei (purple): has joined #vdsm 21:09 -!- nsoffer (Nir Soffer): has joined #vdsm 21:14 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 21:36 -!- pkliczew: has quit [Ping timeout: 240 seconds] 21:56 -!- mpolednik (mpolednik): has joined #vdsm 22:01 -!- mpolednik: has quit [Ping timeout: 276 seconds] 22:09 -!- mmirecki: has quit [Ping timeout: 258 seconds] 22:09 -!- #vdsm ybronhei: has quit [Ping timeout: 276 seconds] 22:11 -!- dkuznets (Dima Kuznetsov): has joined #vdsm 22:17 -!- mpolednik (mpolednik): has joined #vdsm 22:17 -!- fromani: has quit [Quit: Leaving] 22:20 -!- firemanxbr: has quit [Quit: Leaving] 22:24 -!- tiraboschi_: has left #vdsm [] 22:48 -!- ybronhei (purple): has joined #vdsm 23:12 -!- dkuznets: has quit [Ping timeout: 258 seconds] 23:13 -!- #vdsm ybronhei: has quit [Ping timeout: 255 seconds] 23:31 -!- msivak: has left #vdsm [] --- Log closed di mei 19 00:00:14 2015