--- Log opened ma jun 23 00:00:20 2014 00:35 -!- nsoffer: has quit [Read error: Connection reset by peer] 00:38 -!- nsoffer (Nir Soffer): has joined #vdsm 01:41 -!- moolit: has quit [Quit: Leaving.] 01:41 -!- nsoffer: has quit [Ping timeout: 264 seconds] 03:57 -!- mliu (purple): has joined #vdsm 03:57 -!- mliu: has left #vdsm [] 04:18 -!- mliu1 (purple): has joined #vdsm 04:18 -!- mliu1: has left #vdsm [] 04:19 -!- mliu (purple): has joined #vdsm 04:24 -!- mliu: has left #vdsm [] 04:39 -!- apahim: has quit [Quit: Leaving] 04:51 -!- mliu1 (purple): has joined #vdsm 04:51 -!- mliu1: has left #vdsm [] 04:58 -!- adahms: has quit [Ping timeout: 245 seconds] 04:59 -!- adahms (Andrew Dahms): has joined #vdsm 06:10 -!- bala (purple): has joined #vdsm 06:57 -!- #vdsm,#theforeman,#theforeman-dev ybronhei: has quit [Quit: Leaving.] 06:59 -!- xaviern (Xavier): has joined #vdsm 07:16 -!- hchiramm_ (Humble Chirammal): has joined #vdsm 07:23 -!- #vdsm,#theforeman xaviern: has quit [Ping timeout: 255 seconds] 07:34 -!- kobi1 (Kobi Ianko): has joined #vdsm 07:38 -!- xaviern (Xavier): has joined #vdsm 07:42 -!- aravindavk (Aravinda): has joined #vdsm 07:49 -!- ybronhei (purple): has joined #vdsm 07:59 -!- hchiramm__ (Humble Chirammal): has joined #vdsm 07:59 -!- shaohef (shaohef): has joined #vdsm 08:14 -!- nsoffer (Nir Soffer): has joined #vdsm 08:24 -!- bala: has quit [Ping timeout: 264 seconds] 08:24 -!- fromani (Francesco Romani): has joined #vdsm 08:37 -!- fabiand (Fabian Deutsch): has joined #vdsm 08:37 -!- fabiand: has quit [Changing host] 08:37 -!- fabiand (Fabian Deutsch): has joined #vdsm 08:38 -!- hchiramm__ (Humble Chirammal): has joined #vdsm 08:41 -!- bala (purple): has joined #vdsm 08:44 -!- adahms: has quit [Quit: Leaving] 09:04 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 09:19 -!- nsoffer: has quit [Ping timeout: 240 seconds] 09:20 -!- acanan: has quit [Client Quit] 09:20 -!- fromani_ (Francesco Romani): has joined #vdsm 09:22 -!- fromani: has quit [Ping timeout: 245 seconds] 09:24 -!- fromani_: has quit [Client Quit] 09:25 -!- fromani (Francesco Romani): has joined #vdsm 09:31 -!- #vdsm,#theforeman,#theforeman-dev ybronhei: has quit [Ping timeout: 264 seconds] 09:36 -!- bazulay: has quit [Quit: Leaving.] 09:39 -!- evilissimo|afk is now known as evilissimo 09:43 -!- fsimonce (Federico): has joined #vdsm 09:47 -!- ybronhei (purple): has joined #vdsm 09:47 -!- apuimedo (antoni): has joined #vdsm 09:51 < apuimedo> fromani: cool stuff the threadpool 09:51 < apuimedo> I'll try to get a look at the code 09:51 < fromani> apuimedo: thanks, feel free to criticize harshly. At this point I do want to validate the concept, not the code. 09:51 < fromani> apuimedo: ping me anytime if you have any question! 09:51 < apuimedo> very well 09:57 -!- nsoffer (Nir Soffer): has joined #vdsm 09:59 < apuimedo> nsoffer: I didn't get to send the freeze 09:59 < apuimedo> I'll send it now ;-) 09:59 < nsoffer> apuimedo, hi, I'm not sure about this idea 09:59 < apuimedo> so then I won't send it :P 09:59 < apuimedo> nsoffer: do you happen to know why vdsmd and supervdsmd don't talk to each other using AF_UNIX? 10:01 < nsoffer> apuimedo, I think they are 10:01 -!- pkliczew: has quit [Quit: Leaving] 10:02 < apuimedo> nsoffer: didn't find it with a simple git grep 10:02 < apuimedo> for AF_UNIX 10:02 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 10:03 < nsoffer> apuimedo, ADDRESS = os.path.join(constants.P_VDSM_RUN, "svdsm.sock") 10:03 < nsoffer> what kind of address is this? :-) 10:04 < nsoffer> apuimedo, they use multiprocessing 10:04 < apuimedo> ah! 10:05 < apuimedo> nsoffer: thanks ;-) 10:05 < nsoffer> apuimedo, the trouble with freezon concept is that it does not work 10:05 < nsoffer> for example, what does frozen([]) does? 10:05 < nsoffer> apuimedo, can you append items to this list? 10:06 -!- bala: has quit [Quit: Leaving.] 10:06 < nsoffer> apuimedo, python devs rejected this idea 10:06 < apuimedo> nsoffer: I only remember them rejecting to have it for native types 10:06 < nsoffer> apuimedo, http://legacy.python.org/dev/peps/pep-0351/ 10:06 < apuimedo> like frozendict 10:07 < nsoffer> apuimedo, so while frozen() will be very useful for pojo like objects, it can be confusing 10:07 < apuimedo> plain old JAVA objects? 10:07 < apuimedo> xD 10:08 < apuimedo> you implicitly said the name of the beast 10:08 < apuimedo> xD 10:08 < apuimedo> nsoffer: imho it's a documentation and scoping matter 10:09 < apuimedo> and I do like the protocol they propose 10:09 < apuimedo> it's nicely implicit 10:09 < apuimedo> and not so magic 10:12 < apuimedo> https://mail.python.org/pipermail/python-dev/2006-February/060793.html 10:12 < apuimedo> nsoffer: ^^ I can't say I really agree with the points he presents 10:13 < apuimedo> I'd agree about it if it referred to an implementation like mine 10:13 < apuimedo> but the pep one, that all it really does is propose a protocol 10:13 < apuimedo> ... 10:16 -!- #vdsm,#theforeman,#theforeman-dev ybronhei: has quit [Ping timeout: 240 seconds] 10:20 -!- ykaplan (Yeela Kaplan): has joined #vdsm 10:20 < apuimedo> nsoffer: I wish Python had some of Clojure's datastructures 10:21 < apuimedo> that are immutable 10:21 < apuimedo> you append to a list 10:21 < apuimedo> nice, you get a new list 10:21 < apuimedo> and don't alter the data structure the previous references had 10:22 -!- acanan: has quit [Ping timeout: 264 seconds] 10:23 < apuimedo> fabiand: did you see my Friday patches to the node? 10:23 < fabiand> morning apuimedo ! 10:23 < fabiand> apuimedo, yes I did! 10:23 < fabiand> I actually just opened gerrit and looked at your stream! 10:23 < fabiand> apuimedo, kudos and +1! 10:23 < fabiand> :) 10:23 < ewoud> apuimedo: so you'd prefer mynewlist = mylist +:, but with a shorter API? 10:24 < apuimedo> ewoud: I'd like that to be default 10:24 < apuimedo> yes 10:24 -!- bazulay (purple): has joined #vdsm 10:24 -!- bazulay: has quit [Client Quit] 10:25 -!- bazulay (purple): has joined #vdsm 10:25 < apuimedo> fabiand: for some reason the builds fail 10:25 < apuimedo> ryan was looking into it 10:25 < fabiand> apuimedo, that is not because of your patches. it's our default :-( 10:25 < apuimedo> aparently it's some doctext 10:25 < apuimedo> fabiand: xD 10:26 < apuimedo> fabiand: http://gerrit.ovirt.org/#/c/29011/1 and the previous one are pretty obvious 10:26 < apuimedo> and they work just fine 10:26 < apuimedo> at a later point 10:26 < apuimedo> it would be good to replace it with python (It's very easy once we have the mirror operation, which is in the later patches) 10:27 < apuimedo> with these changes, instead of persisting the directory /var/lib/vdsm/persistence 10:27 < apuimedo> I will just persist the symlink 10:27 < apuimedo> and the directory 10:30 < apuimedo> fabiand: do you mind that I'm moving to relative import in http://gerrit.ovirt.org/#/c/29011/1 10:31 -!- ybronhei (purple): has joined #vdsm 10:34 < fabiand> apuimedo, I'll be at your patchset in a min, but in general - not opposed to relative imports 10:34 < apuimedo> fabiand: thanks 10:35 < fromani> a pleasent surprise of this morning: http://fpaste.org/112115/ 10:35 < apuimedo> fromani: api change? 10:35 < fromani> apuimedo: not from me :) 10:35 < apuimedo> fromani: maybe it was the little elves of the night 10:35 < fromani> apuimedo: or maybe this one http://hg.python.org/cpython/rev/43749cb6bdbd 10:35 < fromani> https://bugzilla.redhat.com/show_bug.cgi?id=1103450 10:36 * fromani just upgraded python moments ago... 10:38 < apuimedo> :P 10:41 -!- acanan: has quit [Ping timeout: 240 seconds] 10:42 < fromani> indeed, was that change. Let me write at infra 10:43 -!- mode/#vdsm: by ChanServ 10:43 < apuimedo> danken: boker tov 10:48 < nsoffer> apuimedo, well send the patch, maybe it just a matter of good name 10:49 < apuimedo> nsoffer: now that I saw the protocol way... I'd be more tempted to implement it that way 10:50 < nsoffer> apuimedo, so it will work for any object that implements __freeze__? 10:50 < nsoffer> and breaks loudly for anything else? 10:50 < apuimedo> yup 10:50 < nsoffer> apuimedo, makes sense 10:50 < nsoffer> apuimedo, but we should document that it does not make the object hashable 10:50 < nsoffer> and it is not meant to make it a dict key 10:51 < apuimedo> of course 10:52 < nsoffer> apuimedo, so how will I implement freeze in my status class? 10:52 -!- aravindavk: has quit [Ping timeout: 240 seconds] 10:52 < nsoffer> apuimedo, it seems that I will have to write the same code I have today 10:52 < apuimedo> nsoffer: well, you'd have to have an explicit frozen type 10:52 < apuimedo> yes 10:52 < nsoffer> Than why do I need the frozen magic? 10:53 < apuimedo> no magic 10:53 < nsoffer> apuimedo, I already wrote the fucking boilerplate 10:53 < apuimedo> just it helps the user not have to know which type is the frozen type of a mutable type 10:53 < apuimedo> xD 10:53 < nsoffer> then why not use the frozen class as is? 10:54 <@danken> apuimedo: boker or 10:54 < nsoffer> apuimedo, It does not save me the boilerplate, I don't see a need 10:54 < apuimedo> it's a matter of user convenience 10:54 < apuimedo> and generics 10:55 < nsoffer> apuimedo, generics? why not invent <> fro python? 10:55 < apuimedo> nsoffer: not "generics" but to think in a generic way 10:55 < nsoffer> dict 10:55 < apuimedo> :P 10:55 < apuimedo> arghh 10:55 < apuimedo> You made me remember the C++ template debugging hell 10:56 * apuimedo shudders 10:57 < nsoffer> apuimedo, for the common case of read only attributes, we can use namedtuple 10:57 < nsoffer> so maybe what we need is a nice syntax to create nametuple *without* specifying the attributes names 10:58 < nsoffer> like forzen(cls) -> nametuple(cls.foo, cls.bar, ...) 10:59 < nsoffer> apuimedo, ^^^ 11:00 < apuimedo> :P 11:01 < apuimedo> nsoffer: and store the namedtuple type where? 11:01 < apuimedo> Otherwise you'll be evalling all the time 11:01 < apuimedo> you'd have to keep a dict in the frozen method 11:02 < apuimedo> Type -> namedtuple 11:09 -!- timothy (Timothy Asir): has joined #vdsm 11:10 -!- aravindavk (Aravinda): has joined #vdsm 11:11 -!- mpolednik (Martin Polednik): has joined #vdsm 11:16 -!- mpolednik: has quit [Ping timeout: 240 seconds] 11:17 -!- mpolednik (Martin Polednik): has joined #vdsm 11:28 < apuimedo> fabiand: ping 11:33 < fabiand> apuimedo, pong 12:13 < timothy> danken, i received an email from someone unable to get glusterfs package details though they have installed vdsm-gluster and glusterfs packages 12:13 < timothy> and the vdsm can't seem to find them 12:25 -!- #vdsm,#theforeman,#theforeman-dev ybronhei: has quit [Ping timeout: 255 seconds] 12:25 < nsoffer> apuimedo, create your frozen class and then use it normally 12:25 < apuimedo> ? 12:25 < nsoffer> FrozenYogurt = frozen(Yogurt) 12:26 < nsoffer> return FrozenYogurt(yogurt) 12:26 -!- moolit (purple): has joined #vdsm 12:26 < apuimedo> well, yeah, that's the biolerplate edition you had to make 12:26 < apuimedo> ain't it? 12:26 < nsoffer> apuimedo, no boilerplate 12:27 < nsoffer> apuimedo, ok, one line :-) 12:28 < apuimedo> nsoffer: boilerplate as in "you have to define your frozen class" 12:28 < apuimedo> which was what you wanted to avoid IIRC 12:28 -!- aravindavk: has quit [Ping timeout: 272 seconds] 12:28 < nsoffer> apuimedo, but this replaces 10 lines of boilerplate: http://gerrit.ovirt.org/#/c/29014/1/vdsm/storage/domainMonitor.py 12:29 < nsoffer> apuimedo, 1 < 10 12:30 < apuimedo> I'm afraid I don't see it 12:33 < nsoffer> apuimedo, the problem is that namedtuple __init__ require all fields 12:33 < nsoffer> apuimedo, while our original idea got an instance and made it read only 12:33 < nsoffer> apuimedo, much easier to use 12:35 -!- bala (purple): has joined #vdsm 12:36 < apuimedo> true 12:39 -!- ykaplan: has quit [Ping timeout: 240 seconds] 12:44 -!- bala2 (purple): has joined #vdsm 12:44 -!- aravindavk (Aravinda): has joined #vdsm 12:46 -!- timothy: has quit [Quit: Leaving] 12:47 -!- bala: has quit [Ping timeout: 240 seconds] 12:59 -!- fabiand: has quit [Ping timeout: 245 seconds] 13:02 -!- ykaplan (Yeela Kaplan): has joined #vdsm 13:09 < nsoffer> apuimedo, this is just like namedtuple - you could implement it yourself using @property 13:10 < apuimedo> yeah 13:10 < nsoffer> apuimedo, or you can use the namedtuple and write not code 13:13 < apuimedo> I'm going to get some lunch 13:13 -!- apuimedo is now known as apuimedo|lunch 13:13 -!- moolit: has quit [Ping timeout: 244 seconds] 13:14 -!- moolit (purple): has joined #vdsm 13:16 -!- shaohef: has quit [Ping timeout: 255 seconds] 13:25 -!- danken: has quit [Read error: Connection reset by peer] 13:26 -!- mode/#vdsm: by ChanServ 13:27 -!- ybronhei (purple): has joined #vdsm 13:33 -!- danken: has quit [Quit: Leaving.] 13:39 -!- mode/#vdsm: by ChanServ 13:46 -!- danken: has quit [Quit: Leaving.] 13:49 -!- fabiand (Fabian Deutsch): has joined #vdsm 13:50 -!- fabiand: has quit [Client Quit] 13:50 -!- fabiand (Fabian Deutsch): has joined #vdsm 14:01 -!- mode/#vdsm: by ChanServ 14:12 -!- aravindavk: has quit [Quit: Leaving] 14:26 -!- apuimedo|lunch is now known as apuimedo 14:43 -!- shaohef (shaohef): has joined #vdsm 15:03 < ybronhei> fromani: do you want to push your patch to the github? 15:03 < ybronhei> fromani: or ill do that? 15:03 < fromani> ybronhei: sure, expect a pull request asap 15:03 < ybronhei> https://github.com/ovirt-infra/cpopen . thanks 15:04 < fromani> sure! 15:04 -!- nsoffer: has quit [Ping timeout: 272 seconds] 15:09 < fromani> ybronhei: https://github.com/ovirt-infra/cpopen/pull/24 15:09 -!- gpadgett (Greg Padgett): has joined #vdsm 15:12 < ybronhei> danken: can you review also nsoffer's patch for pthreading. see the pull request on it 15:27 <@danken> ybronhei: I saw his posts 15:28 <@danken> but did not get to them 15:30 -!- pkliczew: has quit [Ping timeout: 240 seconds] 15:30 < ybronhei> yes, it took me also awhile to understand . i can't find problem with that, but i probably miss something again, so please when you have time .. 15:32 -!- AlbertoSilva (AlbertoSilva): has joined #vdsm 15:32 -!- pkliczew (Piotr Kliczewski): has joined #vdsm 15:35 -!- mpolednik: has quit [Ping timeout: 244 seconds] 16:01 -!- #vdsm,#theforeman xaviern: has quit [Ping timeout: 264 seconds] 16:07 -!- nsoffer (Nir Soffer): has joined #vdsm 16:19 -!- nsoffer: has quit [Ping timeout: 240 seconds] 16:32 -!- xaviern (Xavier): has joined #vdsm 16:41 -!- nsoffer (Nir Soffer): has joined #vdsm 16:41 -!- #vdsm,#theforeman xaviern: has quit [Ping timeout: 264 seconds] 16:47 -!- bazulay: has quit [Ping timeout: 240 seconds] 17:05 <@danken> ykaplan: more pep8 erros in http://gerrit.ovirt.org/#/c/26967/ 17:05 -!- kobi1: has quit [Ping timeout: 245 seconds] 17:05 <@danken> pkliczew: any idea what's these http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/3575/console 17:06 <@danken> FAIL: testMethodReturnsNullAndServerReturnsTrue 17:06 -!- moolit: has quit [Remote host closed the connection] 17:08 < apuimedo> going home 17:10 -!- nsoffer: has quit [Ping timeout: 245 seconds] 17:11 -!- moolit (purple): has joined #vdsm 17:12 < ykaplan> danken, fixing , thanks 17:13 -!- apuimedo: has quit [Ping timeout: 255 seconds] 17:16 -!- pkliczew: has quit [Ping timeout: 272 seconds] 17:24 -!- hchiramm_: has quit [Ping timeout: 244 seconds] 17:36 -!- hchiramm_ (Humble Chirammal): has joined #vdsm 17:38 -!- bala2: has quit [Quit: Leaving.] 17:39 -!- sbonazzo: has quit [Quit: Leaving.] 17:46 -!- gpadgett: has quit [Ping timeout: 255 seconds] 17:47 -!- nsoffer (Nir Soffer): has joined #vdsm 17:59 -!- nsoffer: has quit [Ping timeout: 264 seconds] 18:08 -!- acanan: has quit [Ping timeout: 244 seconds] 18:11 -!- fromani: has quit [Quit: Leaving] 18:25 -!- fabiand: has quit [Ping timeout: 264 seconds] 18:28 -!- danken: has quit [Quit: Leaving.] 18:31 -!- mode/#vdsm: by ChanServ 18:34 -!- ykaplan: has quit [Ping timeout: 244 seconds] 18:37 -!- fabiand (Fabian Deutsch): has joined #vdsm 18:52 -!- moolit: has quit [Ping timeout: 264 seconds] 19:01 -!- danken: has quit [Quit: Leaving.] 19:02 -!- mode/#vdsm: by ChanServ 19:21 -!- gpadgett (Greg Padgett): has joined #vdsm 19:26 -!- AlbertoSilva (AlbertoSilva): has joined #vdsm 19:31 -!- danken: has quit [Quit: Leaving.] 19:33 -!- mode/#vdsm: by ChanServ 20:17 -!- fabiand: has quit [Quit: Verlassend] 21:04 -!- danken: has quit [Ping timeout: 240 seconds] 21:18 -!- alitke: has quit [Quit: Leaving] 21:26 -!- AlbertoSilva (AlbertoSilva): has joined #vdsm 21:41 -!- moolit (purple): has joined #vdsm 21:42 -!- nsoffer (Nir Soffer): has joined #vdsm 22:05 -!- nsoffer: has quit [Read error: Connection reset by peer] 22:24 -!- moolit: has quit [Quit: Leaving.] 22:36 -!- nsoffer (Nir Soffer): has joined #vdsm 22:46 -!- moolit (purple): has joined #vdsm 22:56 -!- mode/#vdsm: by ChanServ 23:00 -!- moolit: has quit [Quit: Leaving.] 23:11 -!- apuimedo (antoni): has joined #vdsm 23:15 -!- bazulay (purple): has joined #vdsm 23:17 -!- apuimedo: has quit [Ping timeout: 255 seconds] 23:27 -!- AlbertoSilva (AlbertoSilva): has joined #vdsm 23:29 -!- danken: has quit [Quit: Leaving.] 23:51 -!- moolit (purple): has joined #vdsm --- Log closed di jun 24 00:00:21 2014