--- Log opened zo mrt 24 00:00:54 2013 00:56 -!- shaohef (shaohef): has joined #vdsm 01:09 -!- shaohef: has quit [Ping timeout: 252 seconds] 02:27 -!- shaohef (shaohef): has joined #vdsm 02:29 -!- bala (purple): has joined #vdsm 02:36 -!- bala: has quit [Quit: Leaving.] 02:36 -!- shaohef: has quit [Quit: Leaving.] 02:36 -!- shaohef (shaohef): has joined #vdsm 02:43 -!- shaohef1 (shaohef): has joined #vdsm 02:47 -!- shaohef: has quit [Ping timeout: 256 seconds] 03:32 -!- shaohef1: has quit [Quit: Leaving.] 03:33 -!- shaohef (shaohef): has joined #vdsm 03:45 -!- shaohef: has quit [Quit: Leaving.] 04:00 -!- dougsland (Douglas): has joined #vdsm 07:30 -!- scohen (Sean Cohen): has joined #vdsm 07:38 -!- abaron (Ayal Baron): has joined #vdsm 08:05 -!- ybronhei1: has quit [Quit: Leaving.] 08:41 -!- mode/#vdsm: by ChanServ 08:41 -!- danken (purple): has joined #vdsm 09:03 -!- ykaplan (Yeela Kaplan): has joined #vdsm 09:14 -!- abonas (purple): has joined #vdsm 10:09 -!- apuimedo (antoni): has joined #vdsm 10:10 -!- abonas: has quit [Ping timeout: 259 seconds] 10:25 < apuimedo> danken: looking at the comment about the optimization, I'm tryint to see how much of a difference the second generator makes 10:27 -!- bazulay (purple): has joined #vdsm 10:29 < apuimedo> danken: I was watching this yesterday http://pyvideo.org/video/1690/things-to-make-writing-tests-easier 10:30 < apuimedo> the output of the unit testing comparisons is several orders of magnitude better 10:30 < apuimedo> I was wondering if it would not be worth it to move to it. I would volunteer 10:31 < apuimedo> I mean testfixtures 10:35 -!- abonas (purple): has joined #vdsm 10:39 <@danken> apuimedo: hi 10:39 < apuimedo> danken: hi 10:40 <@danken> apuimedo: regardig generator - I was caring about code readablility, nothing else 10:40 <@danken> which output is better 10:40 <@danken> (11:30:13 AM) apuimedo: the output of the unit testing comparisons is several orders of magnitude better 10:40 <@danken> ? 10:40 < apuimedo> danken: understood. The thing is that IIRC in generators the looping is done at C level 10:41 < apuimedo> yes, it gives much more information if a unit test fails 10:41 < apuimedo> check it out 10:41 < apuimedo> when you have time 10:41 < apuimedo> (I think in Python 3.3 the stdlib unittest already gives better info 10:41 < apuimedo> though) 10:42 <@danken> what is "it"? 10:42 <@danken> the video? 10:44 < apuimedo> yup 10:44 < apuimedo> it talks about different testing frameworks 10:44 < apuimedo> (I have been enjoying the pycon videos :P) 10:47 <@danken> and which framework does he like best? 10:48 < apuimedo> obviosly his :P 10:48 < apuimedo> *obviously 10:48 < apuimedo> I have to check out mock also 10:48 < apuimedo> and compare 10:49 < apuimedo> but I'd consider using some of these 10:51 < apuimedo> danken: I uploaded a version without the second generator, the difference is negligible and it is indeed more readable 10:58 < apuimedo> danken: anyway, most of the time is spent retrieving the xml from the libvirt network object 10:58 < apuimedo> danken: we'd be much much faster if we could get the whole xml for all the networks in one call and parse it ourselves 10:59 < apuimedo> or if when you request a network object from libvirt, it was created with the attributes in memory instead of on-demand 11:08 -!- ybronhei (purple): has joined #vdsm 11:11 <@danken> ybronhei: welcome 11:13 < apuimedo> danken: verified 11:37 <@danken> apuimedo: thanks 11:39 < apuimedo> danken: you're welcome 11:39 < apuimedo> ;-) 11:44 -!- bala (purple): has joined #vdsm 11:49 -!- danken is now known as danken_lunch 11:49 <@danken_lunch> bala: hi! 11:50 <@danken_lunch> bala: could you get your friends understand the unerlying issue of BZ#922744 11:50 <@danken_lunch> bala: using ykaplan's patch? 11:56 -!- ewarszaw (Eduardo Warszawski): has joined #vdsm 12:11 < bala> danken_lunch: sure 12:12 < bala> danken_lunch: i will convey the info 12:15 -!- bala: has quit [Remote host closed the connection] 12:18 -!- bala (purple): has joined #vdsm 12:24 -!- danken_lunch is now known as danken_wfk 12:26 < apuimedo> danken_wfk: working from kitchen? 12:26 <@danken_wfk> apuimedo: nope, from my in-laws' town, Karmiel. 12:27 < apuimedo> danken_wfk: ah! You had to to the long drive ;-) 12:28 < apuimedo> *do 12:28 -!- acathrow (Aic): has joined #vdsm 12:29 -!- bala: has quit [Quit: Leaving.] 12:32 <@danken_wfk> apuimedo: I was even longer, we've been at the Lebanese border overnight. 12:36 <@danken_wfk> apuimedo: is robin@eagleman.net your alias? 12:37 <@danken_wfk> (he just bumped into your otopi fix. suspecious incident ;-) ) 12:37 < ewoud> apuimedo: I'm interested in the patch you're refering to 12:37 < ewoud> with the generator 12:39 <@danken_wfk> ewoud: apuimedo: http://gerrit.ovirt.org/#/c/13159/ 12:42 < ewoud> danken_wfk: thanks 12:52 < apuimedo> danken_wfk: it is not my alias :P 12:53 < apuimedo> danken_wfk: why? 12:53 < apuimedo> I can change the continue to just keep the indentation 12:53 < apuimedo> I'll do so now 12:54 < apuimedo> agreed that it looks better 12:56 < apuimedo> danken_wfk: verifying it... 12:58 -!- abaron: has quit [Ping timeout: 258 seconds] 13:00 -!- abaron (Ayal Baron): has joined #vdsm 13:12 <@danken_wfk> apuimedo: if you prefer the original http://gerrit.ovirt.org/#/c/13159/ (regarding "continue"), why have you changed it? 13:12 <@danken_wfk> do you want me to take it as is, or do a quick fix? 13:15 <@danken_wfk> apuimedo: ah, you have 13:15 <@danken_wfk> but I still do not get it 13:16 <@danken_wfk> you use both "net" and "netObj" for the very same thing! 13:29 <@danken_wfk> apuimedo: I almost forgot our little bug http://gerrit.ovirt.org/#/c/13136/ 13:52 -!- abaron: has quit [Ping timeout: 264 seconds] 13:59 -!- scohen: has quit [Ping timeout: 260 seconds] 14:04 -!- dougsland (Douglas): has joined #vdsm 14:09 < apuimedo> danken_wfk: yeah, I have to verify that 14:09 < apuimedo> and add a bug-url 14:10 < apuimedo> danken_wfk: should I call it net everywhere? 14:10 < apuimedo> or netobj everywhere? 14:31 -!- shaohef (shaohef): has joined #vdsm 14:39 -!- mode/#vdsm: by ChanServ 14:39 -!- danken (purple): has joined #vdsm 14:42 -!- danken_wfk: has quit [Ping timeout: 258 seconds] 14:50 -!- abaron (Ayal Baron): has joined #vdsm 15:02 -!- mohankumar (M. Mohan Kumar): has joined #vdsm 15:04 -!- shaohef: has quit [Ping timeout: 252 seconds] 15:05 -!- scohen (Sean Cohen): has joined #vdsm 15:06 -!- shaohef (shaohef): has joined #vdsm 15:06 -!- abaron: has quit [Ping timeout: 246 seconds] 15:08 -!- abonas: has quit [Ping timeout: 264 seconds] 15:10 -!- shaohef: has quit [Client Quit] 15:16 -!- ewarszaw: has quit [Quit: Konversation terminated!] 15:23 -!- abonas (purple): has joined #vdsm 15:46 -!- abonas: has quit [Quit: Leaving.] 15:52 -!- abonas (purple): has joined #vdsm 15:57 -!- danken: has quit [Quit: Leaving.] 16:06 -!- apuimedo: has quit [Ping timeout: 245 seconds] 16:16 -!- abaron (Ayal Baron): has joined #vdsm 16:53 -!- apuimedo (antoni): has joined #vdsm 16:59 -!- apuimedo: has quit [Ping timeout: 256 seconds] 17:08 -!- mode/#vdsm: by ChanServ 17:08 -!- danken (purple): has joined #vdsm 17:30 -!- scohen: has quit [Ping timeout: 256 seconds] 17:35 -!- abonas: has quit [Ping timeout: 245 seconds] 17:36 -!- abonas (purple): has joined #vdsm 17:38 -!- danken: has quit [Quit: Leaving.] 18:06 -!- mode/#vdsm: by ChanServ 18:06 -!- danken (purple): has joined #vdsm 18:07 -!- ybronhei: has quit [Ping timeout: 248 seconds] 18:09 -!- abonas: has quit [Ping timeout: 252 seconds] 18:10 -!- bazulay: has quit [Quit: Leaving.] 18:11 -!- abonas (purple): has joined #vdsm 18:31 -!- mohankumar: has quit [Ping timeout: 276 seconds] 18:48 -!- ybronhei (purple): has joined #vdsm 18:48 -!- danken: has quit [Quit: Leaving.] 18:53 -!- ykaplan: has quit [Ping timeout: 245 seconds] 19:06 -!- ykaplan (Yeela Kaplan): has joined #vdsm 19:18 -!- ybronhei: has quit [Quit: Leaving.] 19:21 -!- apuimedo (antoni): has joined #vdsm 19:29 -!- Tankado (realname): has joined #vdsm 19:48 -!- abaron: has quit [Ping timeout: 252 seconds] 19:56 -!- Tankado: has left #vdsm ["Leaving"] 20:02 -!- ykaplan: has quit [Ping timeout: 245 seconds] 20:10 -!- danken (purple): has joined #vdsm 20:10 -!- mode/#vdsm: by ChanServ 20:11 -!- Humble (Humble Chirammal): has joined #vdsm 20:28 -!- abonas: has quit [Ping timeout: 248 seconds] 20:36 -!- abaron (Ayal Baron): has joined #vdsm 20:42 -!- danken: has quit [Quit: Leaving.] 20:58 -!- Humble (Humble Chirammal): has joined #vdsm 21:26 -!- ybronhei (purple): has joined #vdsm 21:26 -!- ykaplan (Yeela Kaplan): has joined #vdsm 21:31 -!- ykaplan: has quit [Ping timeout: 240 seconds] 22:29 -!- #rhev,#vdsm dougsland: has quit [Ping timeout: 258 seconds] 22:45 -!- dougsland (Douglas): has joined #vdsm 22:45 -!- dougsland: has quit [Changing host] 22:45 -!- dougsland (Douglas): has joined #vdsm 23:24 -!- dougsland (Douglas): has joined #vdsm 23:24 -!- dougsland: has quit [Changing host] 23:24 -!- dougsland (Douglas): has joined #vdsm 23:25 -!- dougsland (Douglas): has joined #vdsm 23:25 -!- dougsland: has quit [Changing host] 23:25 -!- dougsland (Douglas): has joined #vdsm 23:26 -!- dougsland (Douglas): has joined #vdsm 23:26 -!- dougsland (Douglas): has joined #vdsm 23:29 -!- dougsland: has quit [Changing host] 23:29 -!- dougsland (Douglas): has joined #vdsm 23:29 -!- dougsland (Douglas): has joined #vdsm 23:34 -!- dougsland (Douglas): has joined #vdsm --- Log closed ma mrt 25 00:00:55 2013