--- Log opened ma nov 26 00:00:39 2012 00:05 -!- abaron: has quit [Ping timeout: 256 seconds] 00:53 -!- abaron (Ayal Baron): has joined #vdsm 02:44 -!- sming (New Now Know How): has joined #vdsm 02:45 -!- osier (osier): has joined #vdsm 02:49 -!- mohankumar (M. Mohan Kumar): has joined #vdsm 03:23 -!- bala1 (purple): has joined #vdsm 03:29 -!- bala1: has quit [Quit: Leaving.] 04:01 -!- sming: has quit [Ping timeout: 246 seconds] 04:06 -!- sming (New Now Know How): has joined #vdsm 04:21 -!- sming_ (New Now Know How): has joined #vdsm 04:24 -!- sming: has quit [Ping timeout: 252 seconds] 04:24 -!- sming_ is now known as sming 05:17 -!- sming_ (New Now Know How): has joined #vdsm 05:19 -!- sming: has quit [Ping timeout: 265 seconds] 05:19 -!- sming_ is now known as sming 05:33 -!- mohankumar: has quit [Ping timeout: 245 seconds] 06:07 -!- sming_ (New Now Know How): has joined #vdsm 06:10 -!- sming: has quit [Ping timeout: 260 seconds] 06:10 -!- sming_ is now known as sming 06:48 -!- abaron: has quit [Ping timeout: 260 seconds] 06:57 -!- mohankumar (M. Mohan Kumar): has joined #vdsm 06:59 -!- bala2 (purple): has joined #vdsm 08:04 -!- Humble (Humble Chirammal): has joined #vdsm 08:17 -!- abaron (Ayal Baron): has joined #vdsm 08:30 -!- Humble (Humble Chirammal): has joined #vdsm 08:52 -!- lhornyak (purple): has joined #vdsm 08:55 -!- bazulay (purple): has joined #vdsm 08:55 -!- odedr (purple): has joined #vdsm 09:04 -!- deepakcs (Deepak C Shetty): has joined #vdsm 09:06 -!- apuimedo (Antoni Segura Puimedon): has joined #vdsm 09:08 -!- jlibosva (purple): has joined #vdsm 09:17 -!- Humble (Humble Chirammal): has joined #vdsm 09:21 -!- gpadgett: has quit [Ping timeout: 265 seconds] 09:23 -!- danken (purple): has joined #vdsm 09:23 -!- mode/#vdsm: by ChanServ 09:23 -!- aledvink (Unknown): has joined #vdsm 09:28 -!- ybronhei (purple): has joined #vdsm 09:32 -!- fsimonce (Federico): has joined #vdsm 09:33 -!- gpadgett (Greg Padgett): has joined #vdsm 09:43 -!- rmatinata: has quit [Ping timeout: 244 seconds] 09:52 -!- hchiramm_ (Humble Chirammal): has joined #vdsm 10:08 -!- odedr: has quit [Ping timeout: 276 seconds] 10:13 -!- hchiramm_ (Humble Chirammal): has joined #vdsm 10:20 -!- odedr (purple): has joined #vdsm 10:32 -!- sming: has quit [Ping timeout: 246 seconds] 10:45 -!- dyasny (Dan Yasny): has joined #vdsm 10:53 -!- apahim (Amador Pahim): has joined #vdsm 11:02 -!- bala1 (purple): has joined #vdsm 11:03 -!- bala2: has quit [Read error: Connection reset by peer] 11:08 -!- bala1: has quit [Ping timeout: 260 seconds] 11:11 -!- itamarh (purple): has joined #vdsm 11:16 -!- odedr: has quit [Ping timeout: 248 seconds] 11:16 -!- osier: has quit [Read error: Connection reset by peer] 11:20 -!- bala1 (purple): has joined #vdsm 11:32 -!- odedr (purple): has joined #vdsm 11:35 < deepakcs> How do i get python-pthreading module ? latest vdsm spec has a requires on it. 11:36 < ewoud> deepakcs: https://pypi.python.org/pypi/pthreading/0.1.1 11:38 < deepakcs> ewoud, thanks 11:38 -!- osier (osier): has joined #vdsm 11:41 -!- danpb (purple): has joined #vdsm 11:49 -!- apahim: has quit [Remote host closed the connection] 11:56 -!- apahim (Amador Pahim): has joined #vdsm 12:08 -!- k3rn: has quit [Quit: Leaving] 12:14 -!- k3rn (kern): has joined #vdsm 12:14 -!- k3rn: has quit [Changing host] 12:14 -!- k3rn (kern): has joined #vdsm 12:25 -!- deepakcs: has quit [Remote host closed the connection] 12:40 -!- itamarh: has quit [Ping timeout: 240 seconds] 12:41 -!- apuimedo: has quit [Ping timeout: 252 seconds] 12:49 -!- apuimedo (Antoni Segura Puimedon): has joined #vdsm 12:51 -!- bala1: has quit [Ping timeout: 248 seconds] 12:55 -!- AlbertoSilva (AlbertoSilva): has joined #vdsm 12:57 -!- granha_bola (Fernando Granha Jernimo): has joined #vdsm 13:01 -!- abaron: has quit [Ping timeout: 264 seconds] 13:03 -!- acathrow (Aic): has joined #vdsm 13:03 -!- acathrow: has left #vdsm [] 13:04 -!- bala1 (purple): has joined #vdsm 13:06 -!- odedr: has quit [Ping timeout: 256 seconds] 13:10 -!- apuimedo: has quit [Ping timeout: 250 seconds] 13:14 -!- abaron (Ayal Baron): has joined #vdsm 13:24 -!- odedr (purple): has joined #vdsm 13:24 -!- apuimedo (Antoni Segura Puimedon): has joined #vdsm 13:26 -!- mohankumar: has quit [Ping timeout: 276 seconds] 13:42 -!- Humble (Humble Chirammal): has joined #vdsm 13:46 -!- aledvink: has quit [Ping timeout: 276 seconds] 13:54 -!- apuimedo: has quit [Ping timeout: 245 seconds] 13:59 -!- deepakcs (Deepak C Shetty): has joined #vdsm 14:05 -!- aledvink (Unknown): has joined #vdsm 14:09 -!- apuimedo (Antoni Segura Puimedon): has joined #vdsm 14:12 -!- granha_bola: has quit [Quit: Leaving] 14:12 -!- granha_bola (Fernando Granha Jernimo): has joined #vdsm 14:17 -!- bala1: has quit [Remote host closed the connection] 14:19 -!- deepakcs: has quit [Quit: Leaving] 14:19 -!- aledvink: has quit [Quit: Leaving] 14:20 -!- aledvink (Unknown): has joined #vdsm 14:32 -!- bala1 (purple): has joined #vdsm 14:34 -!- apahim: has quit [Remote host closed the connection] 14:41 -!- rmatinata (Ricardo Marin Matinata): has joined #vdsm 14:42 -!- apahim (Amador Pahim): has joined #vdsm 14:52 -!- rharper (Ryan Harper): has joined #vdsm 15:03 -!- aliguori (Anthony Liguori): has joined #vdsm 15:03 -!- hchiramm_ (Humble Chirammal): has joined #vdsm 15:13 -!- aglitke (Adam Litke): has joined #vdsm 15:16 -!- bala1: has quit [Ping timeout: 259 seconds] 15:18 -!- acathrow1 (Aic): has joined #vdsm 15:25 -!- danken1 (purple): has joined #vdsm 15:25 -!- mode/#vdsm: by ChanServ 15:29 -!- saggi (purple): has joined #vdsm 15:47 -!- ykaplan (Yeela Kaplan): has joined #vdsm 15:50 -!- k3rn: has quit [Ping timeout: 246 seconds] 15:59 -!- bazulay: has quit [Quit: Leaving.] 16:02 -!- Humble (Humble Chirammal): has joined #vdsm 16:02 -!- Humble is now known as Humble_afk 16:03 -!- k3rn (kern): has joined #vdsm 16:03 -!- k3rn: has quit [Changing host] 16:03 -!- k3rn (kern): has joined #vdsm 16:13 -!- abaron: has quit [Ping timeout: 276 seconds] 16:17 -!- rmatinata: has quit [Ping timeout: 264 seconds] 16:17 <@danken1> aglitke: hi adam 16:17 < aglitke> danken1, hey! 16:17 <@danken1> could you take a look at http://gerrit.ovirt.org/#/c/9442/ 16:18 < aglitke> sure 16:18 <@danken1> it annoys us el-6 users 16:19 <@danken1> aglitke: hmm, I suppose that saggi has not poked you about http://gerrit.ovirt.org/#/c/7754/ 16:20 < aglitke> I approved that one awhile ago. Is there anything significant in this new version or is it just a rebase? 16:22 < saggi> aglitke: rebase 16:22 < aglitke> ok, then I can just approve it. Gimme a second. 16:24 -!- abaron (Ayal Baron): has joined #vdsm 16:24 < saggi> You obviously only need to check modified files. 16:29 < aglitke> danken1, Do you happen to have any tracebacks from rhel that I can look at? I want to see if I can fix this better. 16:31 -!- odedr: has quit [Quit: Leaving.] 16:38 -!- granha_bola: has quit [Quit: Leaving] 16:38 -!- granha_bola (Fernando Granha Jernimo): has joined #vdsm 16:44 <@danken1> aglitke: oops, I forgot that I've promised you one. 16:46 <@danken1> aglitke: (we should better get you an el6...) 16:47 <@danken1> saggi: have you seen Royce's take on your NoIntrPoll? 16:47 < saggi> It's Federico's 16:47 < saggi> and no 16:48 <@danken1> aglitke: traceback added: http://gerrit.ovirt.org/#/c/9442/ 16:49 -!- Humble (Humble Chirammal): has joined #vdsm 16:50 <@danken1> saggi: oops, I forgot its fsimonce's. 16:50 <@danken1> anyway, it's broken. 16:50 <@danken1> backport-me-now kind of broken. 16:50 < saggi> let me have a look 16:50 <@danken1> http://gerrit.ovirt.org/#/c/9458/ 16:51 < saggi> danken1: Please stop accepting patches from people inheriting from Thread. Unless they are implementing a new type of thread they shouldn't do it. They are just setting the target. Forcing people to run your stuff in a thread is annoying. Also, starting the thread in the constructor is wrong because you break the Thread interface (That you inherited) and you bind thread creation with construction which is bad practice. 16:51 <@danken1> I think Royce's fix is fine, just wanted to raise the author's attention 16:52 <@danken1> saggi: who has inherited from Thread recently? 16:52 -!- aledvink: has quit [Ping timeout: 246 seconds] 16:52 < saggi> I keep seeing it, I don't want to do git-blame. Just putting it out there 16:52 <@danken1> are you refering to aglitke's momthread? 16:52 < saggi> And just about everything in utils 16:53 <@danken1> saggi: ah, I know you think inheritance is worse than capital punishment. 16:53 -!- jbrooks (Jason Brooks): has joined #vdsm 16:53 < saggi> danken1: If they had actually implemented a new type of thead 16:53 < saggi> I might have let it slide 16:54 < saggi> It's like inheriting from int to implement the number 3 16:55 < saggi> just do a = 3 16:55 <@danken1> only if there where various instances of three. 16:55 -!- jbrooks: has quit [Client Quit] 16:55 < saggi> the target method is a property of a thread, not part of it's identity. 16:56 < saggi> like the value of a string is it's property 16:56 < saggi> even though it's immutable 16:56 < saggi> No one would think to inherit for every string constant 16:56 < saggi> why inherit for every thread target 16:56 -!- apuimedo: has quit [Ping timeout: 260 seconds] 16:58 < fsimonce> danken1, NoIntrPoll was introduced for pipes, sadly it was then used also for something new that translates the exceptions in something different, at least that's what I get from the patch 16:59 -!- osier: has quit [Ping timeout: 260 seconds] 17:00 <@danken1> fsimonce: so you say that IOError is actually valid? 17:00 < fsimonce> and I would suggest (during review too) that we don't remove IOError, just to avoid bothering the author again in the future saying that it doesn't support pipes :-) 17:00 <@danken1> fsimonce: ;-) 17:00 < fsimonce> I think so 17:00 < saggi> danken1: I agree with fsimonce 17:01 < saggi> danken1: It's not that bad BTW, backporting it is not that big of an issue. 17:01 <@danken1> fsimonce: please suggest how to add fix the test, too, to poll pipes. 17:01 < fsimonce> danken1, ok, I'll go ahead a double check the whole thing 17:01 < fsimonce> (and review( 17:02 <@danken1> fsimonce: I see it used only twice: in AsyncProc and in remoteFileHandler 17:02 < fsimonce> yes 17:02 <@danken1> both places have only pipes 17:02 < fsimonce> danken1, yes they use select now though 17:03 <@danken1> fsimonce: ? 17:03 < saggi> danken we don't have any places where we poll actual files sockets 17:03 < saggi> *files or sockets 17:03 -!- granha_bola: has quit [Quit: Leaving] 17:03 <@danken1> saggi: ok, so it's less horrible than I thought. 17:03 -!- granha_bola (Fernando Granha Jernimo): has joined #vdsm 17:03 < saggi> danken1: I'm working on a patch that polls sockets 17:04 < saggi> but it's not even up yet 17:04 -!- danpb: has left #vdsm [] 17:04 < fsimonce> I suppose IOError is thrown when a read/write is failing (vs a select)... I can't remember all the details 17:05 <@danken1> aglitke: I see there's a patch from saggi for you http://gerrit.ovirt.org/#/c/9481/ ;-) 17:05 < saggi> fsimonce: I don't see how they distinguish between the errors. These are C errors after all 17:05 < aglitke> saggi, re the Thread comments. Please post this kind of thing to the mailing list. Also, please mention there what your idea for the correct practice is. 17:05 <@danken1> saggi: ... raised by different modules 17:06 < fsimonce> yes... but I think EAGAIN is an OSError while EINTR is an IOError 17:06 < aglitke> People tend to use existing code as an example for new code. 17:06 < fsimonce> or the opposite 17:06 < aglitke> And that's the way threads have been used. 17:06 <@danken1> (and I would not mind if someone tries out my own http://gerrit.ovirt.org/#/c/9435/ ) 17:07 <@danken1> (little cleanup) 17:08 <@danken1> saggi: on another subject: I got a little tired by http://gerrit.ovirt.org/#/c/9258/ - maybe he'll listen to you. 17:08 <@danken1> "he", meaning ybronhei 17:09 < ybronhei> let me see 17:10 < ybronhei> You never told me anything about that patch and it's there almost a week.... how did you get tired? isn't today Sunday in your location? 17:13 < ybronhei> ah, sorry danken1: I thought saggi wrote this.. I haven't changed much there, just add dmidecode_util that helps to gather the information from python-dmidecode as you suggested.. the patch looks very easy to review (at least to me..) 17:13 < fsimonce> (danken1, saggi, the difference is between multiprocessing.Pipe.poll and select.poll, anyway I'll comment on the patch) 17:13 < saggi> fsimonce: OOOOH 17:17 -!- jbrooks (Jason Brooks): has joined #vdsm 17:30 <@danken1> ybronhei: maybe you'd agree to review and test my http://gerrit.ovirt.org/#/c/9435/ 17:33 < ybronhei> danken1: ok 17:37 -!- jlibosva: has quit [Quit: Leaving.] 17:43 -!- itamarh (purple): has joined #vdsm 17:49 -!- ybronhei: has quit [Ping timeout: 240 seconds] 18:16 -!- apahim: has quit [Read error: Connection reset by peer] 18:17 -!- apahim (Amador Pahim): has joined #vdsm 18:40 -!- lhornyak: has quit [Remote host closed the connection] 18:44 -!- ybronhei (purple): has joined #vdsm 18:54 -!- abaron: has quit [Ping timeout: 252 seconds] 18:54 -!- ilvovsky: has quit [Quit: Leaving] 18:55 -!- ykaplan: has quit [Remote host closed the connection] 19:30 -!- aliguori: has quit [Remote host closed the connection] 19:47 -!- aliguori (Anthony Liguori): has joined #vdsm 19:49 -!- AlbertoS_ (AlbertoSilva): has joined #vdsm 20:37 -!- acathrow1 (Aic): has joined #vdsm 20:38 -!- acathrow1: has left #vdsm [] 21:01 -!- Netsplit *.net <-> *.split quits: apahim, aliguori 21:02 -!- granha_bola: has quit [Quit: Leaving] 21:07 -!- aliguori (Anthony Liguori): has joined #vdsm 21:07 -!- apahim (Amador Pahim): has joined #vdsm 21:13 -!- abaron (Ayal Baron): has joined #vdsm 21:15 -!- danken1: has quit [Quit: Leaving.] 21:16 -!- bazulay (purple): has joined #vdsm 21:27 -!- bazulay: has quit [Quit: Leaving.] 21:30 -!- apuimedo (Antoni Segura Puimedon): has joined #vdsm 21:32 -!- abaron: has quit [Ping timeout: 260 seconds] 21:52 -!- abaron (Ayal Baron): has joined #vdsm 22:03 -!- itamarh: has quit [Quit: Leaving.] 22:11 -!- k3rn: has quit [Read error: Connection timed out] 23:39 -!- apuimedo: has quit [Ping timeout: 260 seconds] --- Log closed di nov 27 00:00:39 2012