--- Log opened wo sep 05 00:00:18 2012 00:12 -!- fsimonce: has quit [Quit: Coyote finally caught me] 00:15 -!- aliguori: has quit [Remote host closed the connection] 00:20 -!- tdfkaSaggi: has quit [Quit: Leaving.] 00:29 -!- ybronhei: has quit [Quit: Leaving.] 01:39 -!- acathrow: has left #vdsm [] 02:42 -!- rharper: has joined #vdsm 04:29 -!- mohankumar: has joined #vdsm 04:31 -!- osier: has joined #vdsm 05:37 -!- bharata: has joined #vdsm 06:40 -!- deepakcs: has joined #vdsm 07:39 -!- supriya: has joined #vdsm 07:52 -!- abaron: has quit [Ping timeout: 246 seconds] 08:00 -!- ybronhei: has joined #vdsm 08:10 -!- aglitke: has quit [Ping timeout: 240 seconds] 08:24 -!- ewarszaw: has quit [Quit: Konversation terminated!] 08:33 -!- bazulay: has joined #vdsm 08:40 -!- aledvink: has joined #vdsm 08:41 -!- lhornyak: has joined #vdsm 08:45 -!- bazulay: has left #vdsm [] 08:50 -!- abaron: has joined #vdsm 08:52 -!- jlibosva: has joined #vdsm 09:07 -!- danken: has joined #vdsm 09:07 -!- mode/#vdsm: by ChanServ 09:12 -!- odedr1: has joined #vdsm 09:30 -!- fsimonce: has joined #vdsm 09:34 -!- dyasny: has joined #vdsm 09:34 -!- dyasny: has left #vdsm [] 09:44 -!- ewarszaw: has joined #vdsm 09:46 -!- apuimedo: has joined #vdsm 09:58 -!- dyasny: has joined #vdsm 10:17 -!- bazulay: has joined #vdsm 10:21 -!- bazulay: has quit [Read error: Connection reset by peer] 10:21 -!- bazulay: has joined #vdsm 10:32 -!- odedr1: has quit [Ping timeout: 248 seconds] 10:38 -!- odedr: has joined #vdsm 10:39 -!- abaron: has quit [Ping timeout: 252 seconds] 10:54 -!- abaron: has joined #vdsm 11:00 -!- osier: has quit [Read error: Connection reset by peer] 11:24 -!- osier: has joined #vdsm 11:25 -!- abaron: has quit [Ping timeout: 264 seconds] 11:26 -!- ybronhei: has quit [Quit: Leaving.] 11:27 -!- ybronhei: has joined #vdsm 11:29 -!- ybronhei: has quit [Client Quit] 11:37 -!- ybronhei: has joined #vdsm 11:38 -!- odedr: has quit [Ping timeout: 240 seconds] 11:38 -!- ybronhei: has quit [Client Quit] 11:38 -!- ybronhei: has joined #vdsm 11:42 -!- abaron: has joined #vdsm 11:44 -!- danpb: has joined #vdsm 11:52 -!- odedr: has joined #vdsm 12:06 -!- supriya: has quit [Ping timeout: 245 seconds] 12:07 -!- danpb: has quit [Remote host closed the connection] 12:16 -!- supriya: has joined #vdsm 12:18 -!- abaron: has quit [Ping timeout: 245 seconds] 12:23 -!- danpb: has joined #vdsm 12:32 -!- abaron: has joined #vdsm 12:36 -!- itamarh: has quit [Quit: Leaving.] 12:36 -!- itamarh: has joined #vdsm 12:49 -!- danpb: has quit [Ping timeout: 245 seconds] 12:57 -!- danpb: has joined #vdsm 13:08 -!- supriya: has quit [Ping timeout: 246 seconds] 13:15 -!- acathrow: has joined #vdsm 13:15 -!- supriya: has joined #vdsm 13:21 -!- apahim: has joined #vdsm 13:26 -!- supriya: has quit [Ping timeout: 244 seconds] 13:30 -!- Humble: has joined #vdsm 13:37 -!- supriya: has joined #vdsm 14:09 -!- trujillo: has joined #vdsm 14:15 -!- bharata: has quit [Quit: Leaving] 14:15 -!- AlbertoSilva: has joined #vdsm 14:22 -!- danpb: has quit [Ping timeout: 240 seconds] 14:24 -!- danpb: has joined #vdsm 14:27 -!- gargya: has joined #vdsm 14:27 -!- danken: has quit [Quit: Leaving.] 14:28 -!- aglitke: has joined #vdsm 14:28 -!- trujillo: has quit [Quit: Leaving] 14:30 -!- trujillo: has joined #vdsm 14:45 -!- aliguori: has joined #vdsm 14:48 -!- trujillo: has quit [Remote host closed the connection] 14:49 -!- trujillo: has joined #vdsm 14:58 -!- supriya: has quit [Quit: Konversation terminated!] 14:59 -!- supriya: has joined #vdsm 15:03 -!- sming: has joined #vdsm 15:20 -!- bazulay: has quit [Quit: Leaving.] 15:23 -!- supriya: has quit [Quit: Konversation terminated!] 15:24 -!- tdfkaSaggi: has joined #vdsm 15:49 < deepakcs> tdfkaSaggi, Hi, i am re-writing the GLUSTERFS_DOMAIN patch with a new class ( instead of reusing nfsSD). Also create mnt/glusterSD as a new mountpath 15:50 < deepakcs> tdfkaSaggi, but facing this issue in sp.py.. Its unable to find the master domain inside mnt/glusterSD.. .. I am missing something in sp.__rebuild 15:50 < tdfkaSaggi> does findDomain find it? 15:51 < deepakcs> tdfkaSaggi, I am running my vdsm standalone script... and it fails at connectStoragePool ( connectstorageserver and createstorage domain/pool has been successfull) 15:51 < deepakcs> tdfkaSaggi, I added code in sdc.py to look for glusterSD mod too so that produce works as expceted 15:52 < deepakcs> tdfkaSaggi, finddomainpath in glusterSD.py has fileSD.scanDomains(sd.GLUSTERSD_DIR) -- i feel thats correct 15:54 < deepakcs> tdfkaSaggi, do i need to add anythign in sp.py __rebuild for SP to find my storage domain which is inside mnt/glusterSD now ? 15:55 < deepakcs> tdfkaSaggi, I believe finddomain finds it as I have gone past the createStorageDomain. 15:55 -!- gargya: has quit [Ping timeout: 246 seconds] 15:57 < tdfkaSaggi> You should add you class to sdc and hsm (for create) 15:57 -!- danpb: has quit [Ping timeout: 260 seconds] 16:00 < deepakcs> tdfkaSaggi, I added for sdc under _finddomain, 'guess i misse dhsm 16:03 < deepakcs> tdfkaSaggi, i already have glusterSD added in hsm. I create the glusterSD instance as part of createStorageDomain 16:03 -!- danpb: has joined #vdsm 16:04 < deepakcs> tdfkaSaggi, any other reason why connectStoragePool isn't able to find my domain. 16:04 < deepakcs> ? 16:05 < tdfkaSaggi> nope, if findDomain finds it, everything should be ok 16:06 < deepakcs> tdfkaSaggi, ya looks like finddomain is not finding it. My glusterSD is inherited from nfsSD 16:06 < deepakcs> will that cause any issues ? 16:07 < tdfkaSaggi> Inheritance shouldn't cause any issues as long as you've overridden all the essential bits. 16:08 < dyasny> apuimedo, pingo 16:11 < deepakcs> tdfkaSaggi, i guess in finddomainPath i need to use "../.." instead of just "..", since my dompath is mnt/glusterSD now 16:13 < deepakcs> tdfkaSaggi, scratch that. thats incorrect 16:13 < deepakcs> tdfkaSaggi, let me debug 16:14 < apuimedo> dyasny: here I am 16:15 < dyasny> apuimedo, hey, I see danken asked you to review my hook code, do you know when you 16:15 < dyasny> ll e able to do that? 16:15 -!- acathrow: has joined #vdsm 16:15 < apuimedo> I just now finished a patch I wanted to do, I'll look into it straight away, sorry for the delay 16:16 < deepakcs> tdfkaSaggi, bingo.. worked.. i had to pass the scandomain pattern as sd.GLUSTERSD_DIR/* ( I was instead passign just sd.GLUSTERSD_DIR) 16:16 < dyasny> apuimedo, thanks, let me know how bad it is :) 16:17 < apuimedo> I'm sure it won't be bad 16:17 -!- acathrow: has joined #vdsm 16:19 -!- danpb: has quit [Ping timeout: 245 seconds] 16:20 -!- deepakcs: has quit [Quit: Leaving] 16:22 -!- gargya: has joined #vdsm 16:23 -!- danpb: has joined #vdsm 16:40 -!- odedr: has quit [Ping timeout: 276 seconds] 16:49 -!- danpb: has quit [Ping timeout: 240 seconds] 16:52 -!- aledvink: has quit [Ping timeout: 255 seconds] 17:04 -!- bazulay: has joined #vdsm 17:04 -!- abaron: has quit [Ping timeout: 252 seconds] 17:25 -!- Humble: has joined #vdsm 17:38 -!- osier: has quit [Ping timeout: 244 seconds] 17:38 -!- jlibosva: has quit [Quit: Leaving.] 17:41 -!- apahim: has quit [Quit: Leaving] 17:41 -!- apahim: has joined #vdsm 17:45 -!- ybronhei: has quit [Ping timeout: 272 seconds] 18:05 -!- gargya: has quit [Quit: ChatZilla 0.9.88.2 [Firefox 10.0.7/20120824135927]] 18:16 -!- sming: has quit [Ping timeout: 252 seconds] 18:34 -!- tdfkaSaggi1: has joined #vdsm 18:34 -!- tdfkaSaggi: has quit [Read error: Connection reset by peer] 18:36 -!- tdfkaSaggi1: has quit [Remote host closed the connection] 19:07 -!- lhornyak: has quit [Ping timeout: 245 seconds] 19:20 -!- mohankumar: has quit [Ping timeout: 248 seconds] 19:47 -!- apahim: has quit [Quit: Leaving] 19:47 -!- apahim: has joined #vdsm 19:53 -!- apuimedo: has quit [Ping timeout: 246 seconds] 19:55 -!- lhornyak: has joined #vdsm 21:21 -!- trujillo: has quit [Ping timeout: 255 seconds] 21:22 -!- tdfkaSaggi: has joined #vdsm 21:37 -!- trujillo: has joined #vdsm 22:47 -!- lhornyak: has quit [Quit: Leaving.] 22:48 -!- apahim: has quit [Quit: Leaving] 22:54 < aglitke> tdfkaSaggi, did you make any changes to your patches since I last reviewed them or did you just rebase and resubmit all of them? It's a lot of work to review them only to find out that you haven't addressed any of my feedback from the last round. 22:56 < tdfkaSaggi> aglitke: I've addressed you're feedback, in the subsequent WIP patch. The originals haven't changed. 22:56 < tdfkaSaggi> I'm removing the entire VM class so our argument becomes invalid 22:57 < aglitke> huh? Whatever happened to incremental changes? 22:57 < tdfkaSaggi> It's incremental. I'm moving the code out of the VM objects 22:58 < tdfkaSaggi> But because I also throw away the REST bindings in another patch, no one uses it anymore. 22:58 < tdfkaSaggi> And in the code I put in BinidngXMLRPC I manually call the wrapper method without any dynamic magic 22:59 < aglitke> I guess gerrit just isn't working very well for me. I just spent an hour going through gerrit review requests only to find the patches are all basically the same. Quite a waste of time I think. 22:59 < tdfkaSaggi> aglitke: admittedly, I'm pretty bad at holding back when it comes to cleaning things up. 22:59 < aglitke> Ran out of time before I got to anything new. 23:00 < tdfkaSaggi> This is new http://gerrit.ovirt.org/#/c/7754/ 23:00 < tdfkaSaggi> And this drastically changed http://gerrit.ovirt.org/#/c/7514/ 23:00 < aglitke> That's ok of you're the only developer, but we need to keep things manageable. 23:01 < tdfkaSaggi> aglitke: I can't help having to rebase 23:01 < tdfkaSaggi> And my non WIP patches are usually static if no one commented on them 23:01 < aglitke> I guess it just gets added to the list of reasons why gerrit doesn't scale in truly distributed open source development environments. 23:01 < tdfkaSaggi> You can compare with older revision in gerrit 23:03 < tdfkaSaggi> aglitke: technically you would have to rereview because something might have gotten broken in the rebase 23:03 < tdfkaSaggi> this happened in more then one occasion. 23:03 < tdfkaSaggi> So this is not really a problem. 23:04 < tdfkaSaggi> We could try and have a system of tagging the commit in a way to express whether a change was automatic (rebase) or manual (amend) 23:04 < aglitke> It wasted an hour of my time :) That is a problem. In regular communities, you only post patches that you actually want reviewed. 23:04 < tdfkaSaggi> I want them reviewed :) 23:04 < tdfkaSaggi> no one reviews them 23:04 < tdfkaSaggi> Some of it should have already gotten in 23:05 < tdfkaSaggi> like http://gerrit.ovirt.org/#/c/7449/ 23:06 < aglitke> Our community has extremely low review bandwidth. 23:06 < tdfkaSaggi> aglitke: That is the big issue. 23:06 < aglitke> So when that is the case, we can't waste reviewer's time on reviewing for rebase errors/ 23:09 < tdfkaSaggi> aglitke: How do you expect to solve it then, even if I would have sent it by email, I would have to send the entire stack so people can apply it and test it. 23:10 < tdfkaSaggi> I can just, not rebase, but that will bite me in the ass when I finally go and rebase. 23:12 -!- #rhev,#vdsm AlbertoSilva: has quit [Remote host closed the connection] 23:12 < aglitke> If you were just rebasing, then you wouldn't send the patches back out. You only resend those patches that need review. 23:13 < aglitke> Also, you work on small sets of isolated patches. 23:13 < aglitke> granted, my libvdsm patch is large but it has a: tag on it. Unfortunately that means almost no one reviews it. 23:14 < tdfkaSaggi> aglitke: I send it out often because I like to keep a gerrit copy with my work up to date. 23:14 < tdfkaSaggi> And I sadly depend on that stack 23:14 < aglitke> Then I will need to learn to ignore gerrit review request emails coming from you. 23:14 < aglitke> Because I cannot tell which ones are real. 23:16 -!- trujillo: has quit [Ping timeout: 244 seconds] 23:16 -!- odedr: has joined #vdsm 23:16 < tdfkaSaggi> aglitke: I rarely send an update without fixing all comments. So if you never commented on a patch before, this is a friendly reminder to comment. It was actually an error on my part of not abandoning the pt.1 and merging it with the WIP 23:27 -!- key: has joined #vdsm 23:30 -!- key: has left #vdsm ["Konversation terminated!"] 23:31 -!- aliguori: has quit [Quit: Ex-Chat] 23:32 -!- aliguori: has joined #vdsm --- Log closed do sep 06 00:00:17 2012