--- Log opened vr jun 19 00:00:56 2026
04:23 -!- Betal: has quit [Quit: WeeChat 4.9.0]
04:48 -!- Betal (Beta): has joined #ovirt
05:26 -!- HrnyVelociraptor[m] (chat.nope:carlsjunior): has joined #ovirt
05:27 -!- HrnyVelociraptor[m]: has left #ovirt []
06:22 -!- rv1sr (rv1sr): has joined #ovirt
06:47 -!- Betal: has quit [Ping timeout: 480 seconds]
07:38 -!- Betal (Beta): has joined #ovirt
09:25 -!- Betal: has quit [Quit: WeeChat 4.9.0]
09:57 -!- FabriceB: has quit [Quit: FabriceB]
10:10 -!- unwillingantKat (unwillingantKathi): has joined #ovirt
10:11 -!- unwillingantKat: has quit [Remote host closed the connection]
10:31 -!- silug0 (Steven Pritchard): has joined #ovirt
10:32 -!- silug: has quit [Ping timeout: 480 seconds]
10:51 -!- FabriceB (FabriceB): has joined #ovirt
11:47 -!- greedyzero[m] (org.matrix:greedyzero): has joined #ovirt
11:55 -!- greedyzero[m]: has left #ovirt [User left]
12:13 -!- c0__LakorMedan (Android IRC Client): has joined #ovirt
12:21 -!- c0__LakorMedan: has quit [Remote host closed the connection]
12:30 -!- Makiyyah (Kiani): has joined #ovirt
12:35 -!- Makiyyah: has quit [Read error: Connection reset by peer]
13:42 < Thidem[m]> Hi, I make different PRs on different project for nvme over tcp, can you just take a time to read the diff and give me your feedback and if I forget to modify something or a other repository. I try on a lab but I am not really sure if my code is correct for other implement than ceph nvme gw. I must take more time to test and check if all is correct but I want to be sure, I have something in ovirt to expose this contribution and if somebody
13:42 < Thidem[m]> need this feature or want to test, they can. 
13:44 -!- Johannes35 (Mike1967GER): has joined #ovirt
13:52 < dupondje[m]> Perfect :) We try to review ASAP :)
13:53 < dupondje[m]> This branch has conflicts that must be resolved :)
13:53 < Thidem[m]> Yes I see with my previous PR...
13:54 < Thidem[m]> I rebase when I finish make all PR
13:54 < dupondje[m]> 👍️
13:58 < dupondje[m]> Somebody did nice work :)
14:00 -!- Johannes35: has quit [Ping timeout: 480 seconds]
14:02 -!- #ovirt,#powerdns jelly: has quit [Remote host closed the connection]
14:05 < Thidem[m]> I hope, I don t forget one repository, I fix my PR 
14:06 -!- jelly (Real Name): has joined #ovirt
14:26 < dupondje[m]> Really nice work ! Going to review it asap. Might want to have some nvme over tcp storage on our end to test also :)
14:28 < Thidem[m]> I have Ceph with NVMe over tcp gateway
14:28 < dupondje[m]> We have NetApp that can do NVMe over TCP
14:28 < dupondje[m]> I'll fix a volume ;)
14:29 < Thidem[m]> I test on this implementation and I am not sure if it works on all implementation and I am not sure if I don t forget something or method to create a storage domain. 
14:32 < Thidem[m]> Normally I use mvn container build to build all artefacts, I think I don t forget any prerequisite. But it is my first contribution on Ovirt, I think it is not perfect but I wait your reviews and feedbacks.
14:33 < dupondje[m]> Didn't look in depth yet, but how do you handle multipathing?
14:38 < Thidem[m]> Normaly, I don t take a time for full test, but if I understand this : https://github.com/orgs/openebs/discussions/3987, it is natively enable. 
14:40 < Thidem[m]> nvm-cli found if it is enable and make the configuration correctly. I use more rbd normally and I am not iscsi / FC expert, all multipath components, it is not directly my speciality.
14:43 < Thidem[m]> I really take time to validate :  if I see the storage, create a volume but actually I don t test HA and multipathing. 
14:46 -!- #ovirt,#powerdns jelly: has quit [Remote host closed the connection]
14:46 < Thidem[m]> I think, I must work more to validate and just to be sure it is bug free. 
14:49 -!- jelly (Real Name): has joined #ovirt
14:50 < Thidem[m]> ```
14:50 < Thidem[m]> would reformat /__w/vdsm/vdsm/tests/storage/nvme_connection_test.py 
14:50 < Thidem[m]> :)
14:50 < dupondje[m]> We enabled liniting on more paths last week, and fixed current code
14:51 < dupondje[m]> Still need way more linting :) But good start already. Just that contributions (and our own code) is a bit aligned
14:53 < Thidem[m]> Really good idea, what is the linter we use ? do you have a command to run before all contributions ? 
14:55 < dupondje[m]> make lint :)
14:56 < Thidem[m]> top I add on pre push 
16:06 < Thidem[m]> Issue with my rebase, I fix it
17:29 -!- logan-: has quit [Ping timeout: 480 seconds]
17:39 -!- logan- (logan): has joined #ovirt
19:03 -!- Betal (Beta): has joined #ovirt
20:12 -!- FabriceB: has quit [Quit: FabriceB]
20:46 -!- acorn (éXpl0îtër's mIRC): has joined #ovirt
21:34 -!- FabriceB (FabriceB): has joined #ovirt
23:12 -!- rv1sr: has quit []
--- Log closed za jun 20 00:00:57 2026